BUG: doing a class method lookup in __dealloc__ is dangerous #44879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems reasonable. if you can rebase as just merged pypy3 in our CI :-> (note we only are supporting >= 3.8) in this release |
Cool!
Done |
|
CI is passing |
|
thanks @mattip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #39777 refactored duplicated code, but caused PyPy to fail. This is because
__dealloc__calledself.close()which strictly speaking is an attribute lookup, and could fail if the object is partially destroyed, as described in the documentation for__dealloc__.Does this need a whatsnew entry?