Skip to content

REF: get regex logic out of Block.replace #44932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 17, 2021
Merged

REF: get regex logic out of Block.replace #44932

merged 2 commits into from
Dec 17, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

This in turn will make it feasible to share Block.replace with Block._replace_coerce i think

@jbrockmendel jbrockmendel mentioned this pull request Dec 17, 2021
Merged
8 tasks
@jreback jreback added Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code labels Dec 17, 2021
@jreback jreback added this to the 1.4 milestone Dec 17, 2021
@jreback jreback merged commit 99524e6 into pandas-dev:master Dec 17, 2021
@jbrockmendel jbrockmendel deleted the ref-replace branch December 17, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback