Skip to content

BUG: encoding_errors=None with read_csv c-engine #45180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 4, 2022
Merged

BUG: encoding_errors=None with read_csv c-engine #45180

merged 4 commits into from
Jan 4, 2022

Conversation

twoertwein
Copy link
Member

@twoertwein twoertwein commented Jan 3, 2022 •
edited
Loading

The c-engine did not handle encoding_errors=None.

The test case for replace was simply wrong in case of read_csv.

Un-blocks @MarcoGorelli's #45173.

@twoertwein twoertwein added the IO CSV read_csv, to_csv label Jan 3, 2022
@twoertwein
Copy link
Member Author

If TextReader had a pyi file and if it wasn't called with **kwargs, this should have been caught by mypy.

@twoertwein
Copy link
Member Author

@jreback If it isn't too late, it would be great to have this for 1.4.

@jreback jreback added this to the 1.4 milestone Jan 4, 2022
@jreback jreback merged commit cbefe18 into pandas-dev:master Jan 4, 2022
@jreback
Copy link
Contributor

jreback commented Jan 4, 2022

thanks @twoertwein

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO CSV read_csv, to_csv
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@twoertwein @jreback