Skip to content

Fixes issue with TextFileReader using python engine and thousands != "," #4602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2013

Conversation

cancan101
Copy link
Contributor

Fixes #4596

@guyrt
Copy link
Contributor

guyrt commented Aug 19, 2013

Related to #4598

I fixed this for floating point numbers in the c parser this weekend.

@jreback
Copy link
Contributor

jreback commented Aug 23, 2013

IIUC #4598 @guyrt is or the c-parser and this PR #4602 @cancan101 for the PythonParser?

@jreback
Copy link
Contributor

jreback commented Aug 23, 2013

@guyrt your tests will hit both c-parse and PythonParser? (I believe you have many more tests as we discussed)

so maybe will merge yours first

@guyrt
Copy link
Contributor

guyrt commented Aug 23, 2013

@jreback you understand correctly. My PR has more tests, but they cover the floating point case. This PR covers thousands separators other than ',' in the PythonParser. They could actually be merged in either order.

@jreback
Copy link
Contributor

jreback commented Aug 23, 2013

@cancan101 ok going to merge this, ready?

@jreback
Copy link
Contributor

jreback commented Aug 23, 2013

@cancan101 I realize need release notes, and can you squash?

@cancan101
Copy link
Contributor Author

OK.

@cancan101
Copy link
Contributor Author

I need to go back and do that for a few of my PRs.

@cancan101
Copy link
Contributor Author

@jreback Should be good to merge

@cancan101
Copy link
Contributor Author

@jreback ping

@jreback
Copy link
Contributor

jreback commented Sep 18, 2013

@cancan101 just need a rebase and can merge

@cancan101
Copy link
Contributor Author

@jreback Okay. Should be rebased.

jreback added a commit that referenced this pull request Sep 19, 2013
Fixes issue with TextFileReader using python engine and thousands != ","
@jreback jreback merged commit d957ad7 into pandas-dev:master Sep 19, 2013
@jreback
Copy link
Contributor

jreback commented Sep 19, 2013

thanks!

@cancan101 cancan101 deleted the number_parsing branch October 20, 2013 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PythonParser::_check_thousands appears broken
3 participants