-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Fixes issue with TextFileReader using python engine and thousands != "," #4602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Related to #4598 I fixed this for floating point numbers in the c parser this weekend. |
IIUC #4598 @guyrt is or the c-parser and this PR #4602 @cancan101 for the PythonParser? |
@guyrt your tests will hit both c-parse and PythonParser? (I believe you have many more tests as we discussed) so maybe will merge yours first |
@jreback you understand correctly. My PR has more tests, but they cover the floating point case. This PR covers thousands separators other than ',' in the PythonParser. They could actually be merged in either order. |
@cancan101 ok going to merge this, ready? |
@cancan101 I realize need release notes, and can you squash? |
OK. |
I need to go back and do that for a few of my PRs. |
@jreback Should be good to merge |
@jreback ping |
@cancan101 just need a rebase and can merge |
@jreback Okay. Should be rebased. |
Fixes issue with TextFileReader using python engine and thousands != ","
thanks! |
Fixes #4596