Bug fix - extension array with 2d datetime64 #46140
Conversation
weikhor
changed the title
…b.com/weikhor/pandas into bug_ExtensionArray_with_2D_datetime64
jreback
added
ExtensionArray
weikhor
changed the title
|
|
Hi, I am still stuck in the PR. Need more time. |
…b.com/weikhor/pandas into bug_ExtensionArray_with_2D_datetime64
|
@jbrockmendel ok here? @weikhor if you can merge master |
|
will take another look today or tomorrow |
| nested_formatter = GenericArrayFormatter(fmt_values) | ||
| return list(nested_formatter.get_result()) | ||
|
|
||
| return list(fmt_values) |
There was a problem hiding this comment.
why is anything necessary between L1630-L1640? we know we have DatetimeIndex which is 1D.
| @@ -3158,6 +3158,97 @@ def format_func(x): | |||
| result = formatter.get_result() | |||
| assert result == ["10:10", "12:12"] | |||
|
|
|||
| def test_datetime64formatter_2d_array(self): | |||
| # GH#38390 | |||
| x = date_range("2018-01-01", periods=10, freq="H").to_numpy() | |||
There was a problem hiding this comment.
nitpick: pls avoid 1-letter variable names. for date_range i like "dti"
|
|
||
| values = self.values | ||
| if not isinstance(values, DatetimeIndex): | ||
| values = DatetimeIndex(values) |
There was a problem hiding this comment.
OK, so there is a deeper bug here in that DatetimeIndex(values) isn't raising when passed a 2D array.
| @@ -1621,18 +1621,23 @@ def __init__( | |||
|
|
|||
| def _format_strings(self) -> list[str]: | |||
| """we by definition have DO NOT have a TZ""" | |||
| values = self.values | |||
There was a problem hiding this comment.
what is the scenario in which we get here with non-1D values? could we just assert 1d-ness at the top and not worry about the rest?
|
Hi It is difficult for me to answer questions provided. I need more time. |
|
I close this since I stuck this for long time. I get simpler task. Thank for review. |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.