Skip to content

REF: avoid python-space calls in _get_dst_hours #46436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 20, 2022
Merged

REF: avoid python-space calls in _get_dst_hours #46436

merged 5 commits into from
Mar 20, 2022

Conversation

jbrockmendel
Copy link
Member

There's still a few more to be gotten, but its a start.

@mroeschke mroeschke added Refactor Internal refactoring of code Timezones Timezone data dtype labels Mar 20, 2022
@mroeschke mroeschke added this to the 1.5 milestone Mar 20, 2022
mroeschke
mroeschke approved these changes Mar 20, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So performance ideally improved here?

@jbrockmendel
Copy link
Member Author

Yah, very small amount

@jreback jreback merged commit 1f8cf19 into pandas-dev:main Mar 20, 2022
@jbrockmendel jbrockmendel deleted the ref-tzconversion branch March 20, 2022 18:45
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@jbrockmendel @yehoshuadimarsky
REF: avoid python-space calls in _get_dst_hours (pandas-dev#46436)
7194cb4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Refactor Internal refactoring of code Timezones Timezone data dtype
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @mroeschke @jreback