Skip to content

Conversation

johnmantios
Copy link
Contributor

…tore

Added test for column-major DataFrames stored in HDFStore which were incorrectly returned as row-major.
Tests and linter pass locally.

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite IO HDF5 read_hdf, HDFStore labels Jul 7, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jul 7, 2022
@mroeschke mroeschke merged commit b4ec020 into pandas-dev:main Jul 7, 2022
@mroeschke
Copy link
Member

Thanks again @johnmantios. Awesome to have these needs tests issues addressed

@johnmantios
Copy link
Contributor Author

No problem @mroeschke. It is a great way for someone to start contributing to open-source!

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
pandas-dev#47616)

TST: Added test for strides in column major Dataframes stored in HDFStore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO HDF5 read_hdf, HDFStore Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Column-major DataFrames stored in HDFStore are returned as row-major
2 participants