Skip to content

TYP: reflect ensure_* function removals #47758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2022
Merged

TYP: reflect ensure_* function removals #47758

merged 1 commit into from
Jul 17, 2022

Conversation

hauntsaninja
Copy link
Contributor

These were removed in #44207

@hauntsaninja hauntsaninja mentioned this pull request Jul 16, 2022
Merged
twoertwein
twoertwein approved these changes Jul 16, 2022
View reviewed changes
Copy link
Member

@twoertwein twoertwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to open an issue to add stubtest to the CI. I assume there are quite a few steps to get to that: new mypy release and fixing/ignoring many files.

@twoertwein twoertwein added the Typing type annotations, mypy/pyright type checking label Jul 16, 2022
@hauntsaninja hauntsaninja mentioned this pull request Jul 16, 2022
Closed
@twoertwein twoertwein merged commit 6251e0b into pandas-dev:main Jul 17, 2022
@twoertwein
Copy link
Member

Thank you @hauntsaninja!

@twoertwein twoertwein added this to the 1.5 milestone Jul 18, 2022
@hauntsaninja hauntsaninja deleted the ensure branch August 25, 2022 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@twoertwein twoertwein twoertwein approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@hauntsaninja @twoertwein