ENH: Move warnings to error/__init__.py per GH27656 #47901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jul 29, 2022
mroeschke
reviewed
Jul 29, 2022
|
In a follow up PR, you could maybe add a pre-commit hook to validate that errors are only defined in |
mroeschke
added
Enhancement
Error Reporting
Gotcha, I'll work on that next |
mroeschke
approved these changes
Aug 8, 2022
|
Thanks again @dataxerik! |
3 tasks
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* ENH: Move warnings to error/__init__.py per GH27656 * ENH: update whatsnew line * ENH: add and re-add final * ENH: add to __all__ * ENH: apply feedback * ENH: fix doc string * ENH: add additional exception/warnings to rst * ENH: fix rst and typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed one of the strings didn't have a
Finalso I've added it.Besides the tslibs and OptionError errors, I think I've moved all the exceptions/warnings to the __errors.py. Is there anything else I should do?