Skip to content

BUG: MultiIndex.unique losing ea dtype #48335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions asv_bench/benchmarks/multiindex_object.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@
import numpy as np

from pandas import (
NA,
DataFrame,
MultiIndex,
RangeIndex,
Series,
date_range,
)

Expand Down Expand Up @@ -255,4 +257,31 @@ def time_operation(self, index_structure, dtype, method):
getattr(self.left, method)(self.right)


class Unique:
params = [
(("Int64", NA), ("int64", 0)),
]
param_names = ["dtype_val"]

def setup(self, dtype_val):
level = Series(
[1, 2, dtype_val[1], dtype_val[1]] + list(range(1_000_000)),
dtype=dtype_val[0],
)
self.midx = MultiIndex.from_arrays([level, level])

level_dups = Series(
[1, 2, dtype_val[1], dtype_val[1]] + list(range(500_000)) * 2,
dtype=dtype_val[0],
)

self.midx_dups = MultiIndex.from_arrays([level_dups, level_dups])

def time_unique(self, dtype_val):
self.midx.unique()

def time_unique_dups(self, dtype_val):
self.midx_dups.unique()


from .pandas_vb_common import setup # noqa: F401 isort:skip
3 changes: 2 additions & 1 deletion doc/source/whatsnew/v1.6.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ Deprecations

Performance improvements
~~~~~~~~~~~~~~~~~~~~~~~~
-
- Performance improvement for :meth:`MultiIndex.unique` (:issue:`48335`)
-

.. ---------------------------------------------------------------------------
Expand Down Expand Up @@ -161,6 +161,7 @@ Missing

MultiIndex
^^^^^^^^^^
- Bug in :meth:`MultiIndex.unique` losing extension array dtype (:issue:`48335`)
- Bug in :meth:`MultiIndex.append` not checking names for equality (:issue:`48288`)
-

Expand Down
2 changes: 1 addition & 1 deletion pandas/core/indexes/multi.py
Original file line number Diff line number Diff line change
Expand Up @@ -1728,7 +1728,7 @@ def get_level_values(self, level):
def unique(self, level=None):

if level is None:
return super().unique()
return self.drop_duplicates()
else:
level = self._get_level_number(level)
return self._get_level_values(level=level, unique=True)
Expand Down
14 changes: 14 additions & 0 deletions pandas/tests/indexes/multi/test_duplicates.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from pandas._libs import hashtable

from pandas import (
NA,
DatetimeIndex,
MultiIndex,
Series,
Expand Down Expand Up @@ -337,3 +338,16 @@ def test_multi_drop_duplicates_pos_args_deprecation():
result = idx.drop_duplicates("last")
expected = MultiIndex.from_arrays([[2, 3, 1], [2, 3, 1]])
tm.assert_index_equal(expected, result)


def test_midx_unique_ea_dtype():
# GH#48335
vals_a = Series([1, 2, NA, NA], dtype="Int64")
vals_b = np.array([1, 2, 3, 3])
midx = MultiIndex.from_arrays([vals_a, vals_b], names=["a", "b"])
result = midx.unique()

exp_vals_a = Series([1, 2, NA], dtype="Int64")
exp_vals_b = np.array([1, 2, 3])
expected = MultiIndex.from_arrays([exp_vals_a, exp_vals_b], names=["a", "b"])
tm.assert_index_equal(result, expected)