Skip to content

Fix build warning for use of strdup in ultrajson #48369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Fix build warning for use of strdup in ultrajson #48369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pandas/_libs/src/headers/portable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
#ifndef _PANDAS_PORTABLE_H_
#define _PANDAS_PORTABLE_H_

// To get `strdup` from strings.h
#ifndef _XOPEN_SOURCE
#define _XOPEN_SOURCE 600
#endif

#include <string.h>

#if defined(_MSC_VER)
#define strcasecmp( s1, s2 ) _stricmp( s1, s2 )
#define strdup _strdup
#endif

// GH-23516 - works around locale perf issues
Expand Down
1 change: 1 addition & 0 deletions pandas/_libs/src/ujson/lib/ultrajson.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ tree doesn't have cyclic references.

#include <stdio.h>
#include <wchar.h>
#include "../../headers/portable.h"

// Don't output any extra whitespaces when encoding
#define JSON_NO_EXTRA_WHITESPACE
Expand Down