TST/CLN: Use fixtures instead of setup_method in tests/indexing #49157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mroeschke
commented
Oct 17, 2022
mroeschke
commented
- Tests added and passed if fixing a bug or adding a new feature
- All code checks passed.
mroeschke
added
Testing
jreback
requested changes
Oct 21, 2022
pandas/tests/indexing/common.py
Outdated
| d = {} | ||
| for typ in self._typs: | ||
| d[typ] = getattr(self, f"{kind}_{typ}") | ||
| def check_result(obj, method, key, axes=None, fails=None): |
There was a problem hiding this comment.
Sure, typed the straightforward args
pandas/tests/indexing/test_iloc.py
Outdated
| @@ -32,7 +32,7 @@ | |||
| ) | |||
| import pandas._testing as tm | |||
| from pandas.api.types import is_scalar | |||
| from pandas.tests.indexing.common import Base | |||
| from pandas.tests.indexing.common import check_result | |||
There was a problem hiding this comment.
maybe rename to assert_result (or something slightly more verbose)
There was a problem hiding this comment.
Renamed to check_indexing_smoketest_or_raises
| self.check_result("loc", key, typs=typs, axes=axes, fails=KeyError) | ||
|
|
||
| def test_loc_getitem_label_list_fails(self): | ||
| @pytest.mark.parametrize("kind", ["series", "frame"]) |
There was a problem hiding this comment.
Don't think it's entirely worth it here. This is just used to combine with another string to fetch a fixture.
jreback
approved these changes
Oct 21, 2022
|
thanks @mroeschke |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.