-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: groupby with dropna=False drops nulls from categorical groupers #49652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mroeschke
merged 22 commits into
pandas-dev:main
from
rhshadrach:groupby_dropna_filtering
Dec 2, 2022
Merged
BUG: groupby with dropna=False drops nulls from categorical groupers #49652
mroeschke
merged 22 commits into
pandas-dev:main
from
rhshadrach:groupby_dropna_filtering
Dec 2, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pby_dropna_filtering
…pby_dropna_filtering � Conflicts: � doc/source/whatsnew/v2.0.0.rst
…ach/pandas into groupby_dropna_filtering � Conflicts: � pandas/core/algorithms.py
rhshadrach
commented
Nov 20, 2022
mroeschke
reviewed
Nov 29, 2022
…pby_dropna_filtering
…ach/pandas into groupby_dropna_filtering
mroeschke
reviewed
Nov 29, 2022
…pby_dropna_filtering
…ach/pandas into groupby_dropna_filtering
mroeschke
reviewed
Dec 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge conflict otherwise LGTM
…pby_dropna_filtering � Conflicts: � pandas/core/groupby/grouper.py
…ach/pandas into groupby_dropna_filtering
mroeschke
approved these changes
Dec 2, 2022
Thanks @rhshadrach |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Categorical
Categorical Data Type
Groupby
Missing-data
np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.The function nunique here is faster than using
pd.unique
, but only works on integers: