Skip to content

TST: add CoW test for update() #51426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2023
Merged

TST: add CoW test for update() #51426

merged 1 commit into from
Feb 16, 2023

Conversation

jorisvandenbossche
Copy link
Member

xref #49473

Under the hood, DataFrame.update() is using .loc setitem, and Series.update() uses _mgr.putmask(..), and both already handle CoW. This is therefore just adding an explicit test for the update() method.

@jorisvandenbossche jorisvandenbossche mentioned this pull request Feb 16, 2023
Closed
73 tasks
@phofl phofl added this to the 2.0 milestone Feb 16, 2023
@phofl phofl merged commit d2c05c4 into pandas-dev:main Feb 16, 2023
@phofl
Copy link
Member

phofl commented Feb 16, 2023

thx @jorisvandenbossche

@jorisvandenbossche jorisvandenbossche deleted the cow-test-update branch February 17, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Copy / view semantics
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jorisvandenbossche @phofl