Skip to content

BUG: assert_frame_equal still checks category dtypes even when asked not to check index type #52216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 1, 2023
Merged

BUG: assert_frame_equal still checks category dtypes even when asked not to check index type #52216

merged 3 commits into from
Apr 1, 2023

Conversation

jayendra-patil33
Copy link
Contributor

@jayendra-patil33 jayendra-patil33 commented Mar 26, 2023 •
edited
Loading

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Categorical Categorical Data Type labels Mar 27, 2023
@mroeschke
Copy link
Member

Looks pretty good. Could use a whatsnew note in v2.0.1.rst

@jayendra-patil33
Copy link
Contributor Author

@mroeschke done

@mroeschke mroeschke added this to the 2.1 milestone Apr 1, 2023
@mroeschke mroeschke merged commit d69eaae into pandas-dev:main Apr 1, 2023
@mroeschke
Copy link
Member

Thanks @jayendra-patil33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Categorical Categorical Data Type Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

BUG: assert_frame_equal still checks category dtypes even when asked not to check index type
2 participants
@jayendra-patil33 @mroeschke