Skip to content

CI: update autotyping #52232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2023
Merged

CI: update autotyping #52232

merged 2 commits into from
Mar 27, 2023

Conversation

twoertwein
Copy link
Member

Added many of the --guess-common-names guestimations. This new option would still make changes, so I disabled it.

@twoertwein twoertwein requested a review from MarcoGorelli March 27, 2023 04:04
@MarcoGorelli MarcoGorelli added the Code Style Code style, linting, code_checks label Mar 27, 2023
@MarcoGorelli MarcoGorelli added this to the 2.1 milestone Mar 27, 2023
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks @twoertwein !

@@ -4306,7 +4306,7 @@ def __delitem__(self, key) -> None:
# Unsorted

@final
def _check_inplace_and_allows_duplicate_labels(self, inplace):
def _check_inplace_and_allows_duplicate_labels(self, inplace: bool_t):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was bool, had to change it to bool_t

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that's what I meant, I presume the other hook caught this one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mypy made me change it :)

@MarcoGorelli MarcoGorelli merged commit e63e2af into pandas-dev:main Mar 27, 2023
@twoertwein twoertwein deleted the autotyping branch August 9, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants