DataFrame.join Copy-on-Write optimization tests #52751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SecretLake
changed the title
|
Thanks for the PR @SecretLake! The CI caught some errors which I think you can solve locally if you run pre-commit. Let us know if you need help. |
|
Thanks for the feedback @noatamir. I don‘t see any errors in the CI. Could you pls point me to the failed runs? |
|
Oops. I thought I saw one earlier. My bad 🙈 |
phofl
reviewed
Apr 19, 2023
| shares the same memory with original dataframes until it is edited. | ||
| """ | ||
| df1 = DataFrame({"key": ["a", "b", "c"], "a": [1, 2, 3]}) | ||
| df2 = DataFrame({"key": ["a", "b", "c"], "b": [4, 5, 6]}) |
There was a problem hiding this comment.
Can you define index=Index(["a", "b", "c"], name="key") instead of using it as a column? We always try to create a test with the least number of operations possible
There was a problem hiding this comment.
Sure, thank you for the review. Implemented changes based on the comments.
|
|
||
|
|
||
| def test_join_on_key(using_copy_on_write): | ||
| """Test if DataFrame.join applies Copy-On-Write optimization. |
There was a problem hiding this comment.
Can you remove the comment? We generally don't add comments in tests
phofl
approved these changes
Apr 21, 2023
phofl
added
Reshaping
|
thx @SecretLake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@phofl @noatamir @jorisvandenbossche @MarcoGorelli Could you guys please review this PR? Thanks again for the session today.