Skip to content

TYP: Use Protocol for ReaderBase #52915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2023
Merged

TYP: Use Protocol for ReaderBase #52915

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d1e2e4
TYP: Use Protocol for ReaderBase
mroeschke Apr 25, 2023
a14566e
Merge remote-tracking branch 'upstream/main' into typ/protocol
mroeschke Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions pandas/io/sas/sasreader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,10 @@
"""
from __future__ import annotations

from abc import (
ABCMeta,
abstractmethod,
)
from typing import (
TYPE_CHECKING,
Hashable,
Protocol,
overload,
)

Expand All @@ -31,19 +28,16 @@
from pandas import DataFrame


# TODO(PY38): replace with Protocol in Python 3.8
class ReaderBase(metaclass=ABCMeta):
class ReaderBase(Protocol):
"""
Protocol for XportReader and SAS7BDATReader classes.
"""

@abstractmethod
def read(self, nrows: int | None = None) -> DataFrame:
pass
...

@abstractmethod
def close(self) -> None:
pass
...

def __enter__(self) -> ReaderBase:
return self
Expand Down