Skip to content

BUG: overriden methods of subclasses of Styler are not called during rendering #52728 #52919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 27, 2023

Conversation

nicklausroach
Copy link
Contributor

@rhshadrach rhshadrach added Bug Styler conditional formatting using DataFrame.style Subclassing Subclassing pandas objects labels Apr 25, 2023
@nicklausroach nicklausroach requested a review from attack68 April 27, 2023 05:59
Copy link
Contributor

@attack68 attack68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@mroeschke mroeschke added this to the 2.1 milestone Apr 27, 2023
@mroeschke mroeschke merged commit 0c198e7 into pandas-dev:main Apr 27, 2023
@mroeschke
Copy link
Member

Thanks @nicklausroach

topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 7, 2023
…rendering pandas-dev#52728 (pandas-dev#52919)

* use type() instead of __class__

* add test

* remove unnecessary file

* typo

* revert change to class method

---------

Co-authored-by: Nicklaus Roach <[email protected]>
Co-authored-by: Nicklaus Roach <[email protected]>
Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
…rendering pandas-dev#52728 (pandas-dev#52919)

* use type() instead of __class__

* add test

* remove unnecessary file

* typo

* revert change to class method

---------

Co-authored-by: Nicklaus Roach <[email protected]>
Co-authored-by: Nicklaus Roach <[email protected]>
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
…rendering pandas-dev#52728 (pandas-dev#52919)

* use type() instead of __class__

* add test

* remove unnecessary file

* typo

* revert change to class method

---------

Co-authored-by: Nicklaus Roach <[email protected]>
Co-authored-by: Nicklaus Roach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Styler conditional formatting using DataFrame.style Subclassing Subclassing pandas objects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: overriden methods of subclasses of Styler are not called during rendering
4 participants