STY: Enable B904 #56941
Merged
STY: Enable B904 #56941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqa236
requested review from
attack68,
MarcoGorelli and
datapythonista
as code owners
|
All tests passed after I ... added more info to debug. Not sure if I'm just unlucky with the flaky test or if there's a subtle error the test suite can't capture. The failed test in the previous commit is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think most of the fixes should be straightforward. For a few complex cases, I think it's reasonable to
noqathem to allow us to enable a global check to the rest of the codebase.doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.