REGR: assert_series_equal defaulting to check_exact=True for Index #57341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Testing
mroeschke
approved these changes
Feb 12, 2024
|
Thanks @phofl |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 12, 2024
… check_exact=True for Index
mroeschke
pushed a commit
that referenced
this pull request
Feb 12, 2024
…ing to check_exact=True for Index) (#57380) Backport PR #57341: REGR: assert_series_equal defaulting to check_exact=True for Index Co-authored-by: Patrick Hoefler <[email protected]>
rhshadrach
reviewed
Feb 12, 2024
| @@ -902,6 +902,7 @@ def assert_series_equal( | |||
| >>> tm.assert_series_equal(a, b) | |||
| """ | |||
| __tracebackhide__ = True | |||
| check_exact_index = False if check_exact is lib.no_default else check_exact | |||
There was a problem hiding this comment.
Don't we want to default to check_exact=True for integers and false for floats?
There was a problem hiding this comment.
I wasn't a fan of doing the breaking change in a minor release, that's why I reverted back to 2.1.x behaviour for Index. We can introduce the more intelligent behavior for 3.0 if someone wants to do it
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.