Skip to content

Conversation

pedrocariellof
Copy link
Contributor

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks pretty good, a few requests below.

@rhshadrach rhshadrach added Groupby Deprecate Functionality to remove in pandas labels May 15, 2024
@pedrocariellof pedrocariellof requested a review from rhshadrach May 27, 2024 15:22
@pedrocariellof
Copy link
Contributor Author

@rhshadrach

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, a few minor requests.

@pedrocariellof pedrocariellof requested a review from rhshadrach June 1, 2024 02:10
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added this to the 3.0 milestone Jun 3, 2024
@rhshadrach rhshadrach merged commit 76c7274 into pandas-dev:main Jun 3, 2024
@rhshadrach
Copy link
Member

Thanks @pedrocariellof - and for the additional cleanups too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Groupby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEPR: groupby.corrwith
3 participants