BUG: Integer values at the top end of the supported range incorrectly… #59310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… interpreted as missing for format versions 111 and prior
…constructing StataMissingValue from value
mroeschke
approved these changes
Jul 25, 2024
|
Thanks @cmjcharlton |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… interpreted as missing for format versions 111 and prior
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.There are several ways that this could be solved. As Pandas doesn't support writing data in the applicable format versions I have taken the minimal approach here of expanding the integer limits to their documented maximums for these older versions, and recoding the old missing value for (.) to its current equivalent.