Skip to content

DOC: add api.types.is_dtype_equal into document #61394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 3, 2025

Conversation

chilin0525
Copy link
Contributor

@chilin0525 chilin0525 commented May 3, 2025

@chilin0525 chilin0525 marked this pull request as draft May 3, 2025 07:45
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added some comments with needed format changes, but other than that looks perfect. Thank you for the PR

target : The second dtype to compare
source : dtype
The first dtype to compare
target : dtype
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in 7ca7023.

@datapythonista datapythonista added Docs Dtype Conversions Unexpected or buggy dtype conversions labels May 3, 2025
@chilin0525
Copy link
Contributor Author

@datapythonista Thank you for the review and for pointing out how to fix the CI error! 🙏

@chilin0525 chilin0525 marked this pull request as ready for review May 3, 2025 17:08
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the contribution @chilin0525

@datapythonista datapythonista merged commit 337d40e into pandas-dev:main May 3, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Should pandas.api.types.is_dtype_equal() be documented?
2 participants