-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: add api.types.is_dtype_equal
into document
#61394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…n for api.types.is_dtype
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, added some comments with needed format changes, but other than that looks perfect. Thank you for the PR
pandas/core/dtypes/common.py
Outdated
target : The second dtype to compare | ||
source : dtype | ||
The first dtype to compare | ||
target : dtype |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in 7ca7023.
Co-authored-by: Marc Garcia <[email protected]>
Co-authored-by: Marc Garcia <[email protected]>
Co-authored-by: Marc Garcia <[email protected]>
@datapythonista Thank you for the review and for pointing out how to fix the CI error! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the contribution @chilin0525
pandas.api.types.is_dtype_equal()
be documented? #60905doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.