Improve MultiIndex label rename checks #61769
Conversation
TabLand
force-pushed
the
correct-multi-index-rename-checks
branch
from
d700c92 to
6b7cba3
Compare
pandas/core/generic.py
Outdated
| indexers = [ | ||
| ax.get_level_values(i).get_indexer_for([replacement]) | ||
| for i in range(ax.nlevels) | ||
| if i == level or level is None | ||
| ] |
There was a problem hiding this comment.
I think MultiIndex.get_indexer_for should work with for an iterable of tuples, so I would look into why that isn't working as opposed to working around it here
TabLand
force-pushed
the
correct-multi-index-rename-checks
branch
from
6b7cba3 to
0fd6ca7
Compare
| @@ -6429,12 +6429,15 @@ def _transform_index(self, func, *, level=None) -> Index: | |||
| Only apply function to one level of the MultiIndex if level is specified. | |||
| """ | |||
| if isinstance(self, ABCMultiIndex): | |||
| values = [ | |||
| self.get_level_values(i).map(func) | |||
| if i == level or level is None | |||
There was a problem hiding this comment.
@mroeschke - I've managed to trace this issue to this line here. The Index._transform_index function is only used in one other place: merge.py>_items_overlap_with_suffix
Checking if this has had an adverse impact on other tests...
There was a problem hiding this comment.
It looks like certain existing transformations have to be applied to each individual level component of a MultiIndex, whereas others make more sense to apply to the entire thing.
I'm guessing a new parameter to DataFrame.rename() is needed which could then be cascaded down to Index._transform_index()? Something like scope: {"full", "partial"}?
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.