Skip to content

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Dec 6, 2014

Closes #9027

@cpcloud cpcloud self-assigned this Dec 6, 2014
@cpcloud cpcloud added this to the 0.15.2 milestone Dec 6, 2014
@cpcloud cpcloud added Bug IO Data IO issues that don't fit into a more specific label IO JSON read_json, to_json, json_normalize labels Dec 6, 2014
'b': [1, 2]})
result = pd.read_json(frame.to_json())
result['a'] = pd.to_timedelta(result.a, unit='ns')
assert_frame_equal(frame, result)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a Timestamp in there as well for the test?

@cpcloud
Copy link
Member Author

cpcloud commented Dec 7, 2014

@jreback refactored to have a single total_seconds function in datetime_helper.h

@jreback
Copy link
Contributor

jreback commented Dec 7, 2014

cool rebase and merge in green

@jreback
Copy link
Contributor

jreback commented Dec 7, 2014

looks good. ready to merge?

cpcloud added a commit that referenced this pull request Dec 7, 2014
Implement timedeltas for to_json
@cpcloud cpcloud merged commit c0a79e1 into pandas-dev:master Dec 7, 2014
@cpcloud cpcloud deleted the timedelta-json branch December 7, 2014 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug IO Data IO issues that don't fit into a more specific label IO JSON read_json, to_json, json_normalize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: to_json failing on mixed with Timedelta
2 participants