Fix bug in multiindex series groupby where sort argument is ignored #9461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
looks good |
| names=['a', 'b']) | ||
| self.mseries = Series([0, 1, 2, 3, 4, 5], index=index) | ||
| index = MultiIndex(levels=[[1, 2], [1, 2]], | ||
| labels=[[0, 0, 1], [1, 0, 0]], |
There was a problem hiding this comment.
actually
move these into the actual test function
they only need to be created once
if they are in the setup they will be for every test - which is not necessary
…issue 9444). One test added.
cottrell
force-pushed
the
groupby_sort
branch
from
5007df3 to
1bcfe35
Compare
|
@cottrell looks good now. thanks. ping when green. |
|
does this also fix #8868 ? |
|
ok gr8 thanks |
jreback
added a commit
that referenced
this pull request
Feb 11, 2015
Fix bug in multiindex series groupby where sort argument is ignored
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR as per.
One test added. Test fails without the fix.
closes #9444