Skip to content

chore(ci): update hive rpc-compat expected failures #13424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2024
Merged

chore(ci): update hive rpc-compat expected failures #13424

merged 1 commit into from
Dec 17, 2024

Conversation

fgimenez
Copy link
Member

After #13303 some rpc-compat tests previously failing bc of rpc responses including totalDifficulty are passing, eg. https://github.com/paradigmxyz/reth/actions/runs/12372646231/job/34532049787

Unexpected Passes: ['eth_getBlockByHash/get-block-by-hash (reth)', 'eth_getBlockByNumber/get-block-n (reth)', 'eth_getBlockByNumber/get-finalized (reth)', 'eth_getBlockByNumber/get-genesis (reth)', 'eth_getBlockByNumber/get-latest (reth)', 'eth_getBlockByNumber/get-safe (reth)']

@mattsse mattsse added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit dc7818c Dec 17, 2024
45 checks passed
@mattsse mattsse deleted the fgimenez/update-rpc-compat-expected-failures branch December 17, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fgimenez @mattsse