Skip to content

feat(rpc): add block timestamp to logs #7606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

cairoeth
Copy link
Contributor

@cairoeth cairoeth commented Apr 12, 2024

closes #6752, may need some specific tests -- are there any references of tests that check log returns?

@cairoeth cairoeth changed the title fix(rpc): add block timestamp to logs feat(rpc): add block timestamp to logs Apr 12, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

smol suggestion

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great ty!

@mattsse mattsse added C-enhancement New feature or request A-rpc Related to the RPC implementation labels Apr 12, 2024
@mattsse mattsse enabled auto-merge April 12, 2024 20:08
@mattsse mattsse added this pull request to the merge queue Apr 12, 2024
Merged via the queue into paradigmxyz:main with commit 041e293 Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: extend eth_getLogs RPC to return blockTimestamp in the log object response
2 participants