Skip to content

Remove references to key lifetime #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

hug-dev
Copy link
Member

@hug-dev hug-dev commented Oct 22, 2019

Removes all key lifetime after parallaxsecond/parsec-operations#2.

This will not compile until version 0.1.1 is made on parsec-operations containing the changes.

@hug-dev hug-dev requested a review from ionut-arm October 22, 2019 13:17
@hug-dev hug-dev self-assigned this Oct 22, 2019
hug-dev added a commit to hug-dev/parsec that referenced this pull request Oct 22, 2019
Changes needed after they were removed from
parallaxsecond/parsec-interface-rs#5.

Signed-off-by: Hugues de Valon <[email protected]>
@ionut-arm
Copy link
Member

ionut-arm commented Oct 22, 2019

This will not compile until version 0.1.1 is made on parsec-operations containing the changes.

Maybe 0.2.0 is better as we are breaking the functionality (although given semantic versioning rules, maybe we should be calling it 1.0.0; but since we've not released a proper functioning service yet, 0.2.0 could do, or just moving 0.1.0 from the old commit to the new one)

@hug-dev
Copy link
Member Author

hug-dev commented Oct 22, 2019

I think using 0.2.0 is a better idea.

hug-dev added a commit to hug-dev/parsec-client-test that referenced this pull request Oct 22, 2019
Changes needed after they were removed from
parallaxsecond/parsec-interface-rs#5.

Signed-off-by: Hugues de Valon <[email protected]>
Removes all key lifetime after parallaxsecond/parsec-operations#2.

Signed-off-by: Hugues de Valon <[email protected]>
@hug-dev
Copy link
Member Author

hug-dev commented Oct 23, 2019

The PR on operations is merged and the checks now pass!

@hug-dev hug-dev merged commit d3288df into parallaxsecond:master Oct 23, 2019
hug-dev added a commit to hug-dev/parsec that referenced this pull request Oct 23, 2019
Changes needed after they were removed from
parallaxsecond/parsec-interface-rs#5.

Signed-off-by: Hugues de Valon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants