Skip to content

Add support for passing clippy arguments in comment-able file #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 13, 2022
Merged

Conversation

gbhand
Copy link
Collaborator

@gbhand gbhand commented Jul 12, 2022

Background

As described in monorail#1298, larger-scale CI workflows (often using >100 clippy arguments) are difficult to maintain and understand without the ability to add comments.

Description

Added support for reading clippy args from an sh-style file specified by the args-file parameter. Each individual argument may be on same or different lines. Full-line comments are supported for better organization and clarification. Inline comments are not supported.

Verification

Copy link

@joshparallel joshparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Couple tiny comments.

@gbhand gbhand requested a review from joshparallel July 13, 2022 18:44
Copy link

@joshparallel joshparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gbhand gbhand merged commit a2c0110 into parallelsystems:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants