Upgrade to Node16 and update dependencies #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed d impossible arg conditional * Added other conditional too * Restored upstream formatting
* Filter out blank lines * WIP * WIP * WIP * WIP * WIP * Revert package.json and package-lock.json
klimburg
approved these changes
Nov 30, 2022
klimburg
suggested changes
Nov 30, 2022
There was a problem hiding this comment.
looks like there is an issue when you actually used this branch in monorail
https://github.com/parallelsystems/monorail/actions/runs/3579495678
|
@klimburg looks like this is unfortunately the expected behavior: Pull requests from forks cannot create Checks due to security exposure. Besides this error (which should no longer occur once merged to master) the rest of the output looks successful. Is that sufficient to get this merged? |
klimburg
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
GitHub Actions is deprecating Node12 https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
Description
This PR upgrades the action to use Node16, along with updating dependencies. In order to upgrade to Node16, error handling had to be changed from
to
as
catchblocks now are type annotated (microsoft/TypeScript#36775)Verification
Passes local tests