Skip to content

File downloads are empty #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CodeGenie1 opened this issue Mar 15, 2019 · 3 comments
Closed

File downloads are empty #117

CodeGenie1 opened this issue Mar 15, 2019 · 3 comments

Comments

@CodeGenie1
Copy link

Hi Phil,
spotted this one trying to download a bitmap image stored in parse. When you call (with await) the parse_file download method, it is returning ok and the file is created in the cache directory but it has zero bytes. I think the issue is simply that the file.writeAsBytes(response.bodyBytes) at line 68 in parse_file is not being awaited, so nothing is written to the file. You could use the writeAsBytesAsync method instead or just await.

@RodrigoSMarques
Copy link
Contributor

Resolved in Pull Request #123 . Wait for the merge

@phillwiggins
Copy link
Member

Resolved on branch 1.0.16. Will be released shortly.

Thanks @RodrigoSMarques for the fix.

@RodrigoSMarques
Copy link
Contributor

@phillwiggins
this issue can be closed.

Resolved in the last release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants