Skip to content

LiveQuery needs refactoring #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rostopira opened this issue Jul 10, 2019 · 7 comments
Closed

LiveQuery needs refactoring #217

rostopira opened this issue Jul 10, 2019 · 7 comments

Comments

@rostopira
Copy link
Contributor

rostopira commented Jul 10, 2019

Current implementation spawns new separate websocket connection for every subscription
This is huge overkill and will likely cause additional load on server

@arvanus
Copy link

arvanus commented Aug 23, 2019

@rostopira are LiveQuery working for you?
See #198

@rostopira
Copy link
Contributor Author

Yes, it works, because I'm using release branch, read last comment on issue
It also works on Flutter Web

@phillwiggins
Copy link
Member

Hey @rostopira

Can you look at the Web Live Query stuff you wrote. It seems to be listing invalid libraries and has dragged our Flutter library score on Pub Dev to a really low level. It looks as though something is missing? It ideally needs a hotfix pretty promptly.

@rostopira
Copy link
Contributor Author

The only thing that it uses is dart:html, and it's valid library. But Dart Analyzer doesn't think so, see: flutter/flutter#35588

@rostopira
Copy link
Contributor Author

rostopira commented Aug 23, 2019

Actually, using import 'dart:html' as HTML; make dart analyzer scream on this line only, so I will provide PR with that
UPD: this should make analyzer shut up

// ignore: uri_does_not_exist
import 'dart:html' as HTML;

@rostopira
Copy link
Contributor Author

@phillwiggins PR is ready to merge

@phillwiggins
Copy link
Member

phillwiggins commented Aug 23, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants