-
-
Notifications
You must be signed in to change notification settings - Fork 207
LiveQuery needs refactoring #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@rostopira are LiveQuery working for you? |
Yes, it works, because I'm using release branch, read last comment on issue |
Hey @rostopira Can you look at the Web Live Query stuff you wrote. It seems to be listing invalid libraries and has dragged our Flutter library score on Pub Dev to a really low level. It looks as though something is missing? It ideally needs a hotfix pretty promptly. |
The only thing that it uses is |
Actually, using // ignore: uri_does_not_exist
import 'dart:html' as HTML; |
@phillwiggins PR is ready to merge |
Greatly appreciated!
…On Fri, Aug 23, 2019, 17:12 Dima Rostopira ***@***.***> wrote:
Actually, using import 'dart:html' as HTML; make dart analyzer scream on
this line only, so I will provide PR with that
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#217>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB4CPXVRB5KD6HDA6VUP3XTQGAD7LANCNFSM4H7RJS6Q>
.
|
Uh oh!
There was an error while loading. Please reload this page.
Current implementation spawns new separate websocket connection for every subscription
This is huge overkill and will likely cause additional load on server
The text was updated successfully, but these errors were encountered: