Copy an object

[fischerscode]

As described on #267, I am trying to copy an ordinary ParseObject.
object?.clone(object?.toJson(full: true));

This throws an error for me:
Unhandled Exception: type 'ParseACL' is not a subtype of type 'Map<String, dynamic>'

This makes sens, as _getObjectData()[keyVarAcl] = ParseACL().fromJson(value); is called in parse_base.dart (line 139). With value being a ParseACL and fromJson taking a Map.

Am I just stupid or is there something wrong?

[fischerscode]

@phillwiggins
This is needed for the improvement mentioned in #324 (comment).

[fischerscode]

Adding
if (value is ParseACL) { return value.toJson(); }
into dynamic parseEncode(dynamic value, {bool full}) (parse_encoder.dart) fixes this.

I think this should break nothing.

[phillwiggins]

I think that sounds like a good idea. Shall we add it and test?

…

On Tue, 10 Mar 2020, 14:26 Maximilian Fischer, ***@***.***> wrote: Adding if (value is ParseACL) { return value.toJson(); } into dynamic parseEncode(dynamic value, {bool full}) (parse_encoder.dart) fixes this. I think this should break nothing. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#325?email_source=notifications&email_token=AB4CPXRV5BSLYBCKON62DTLRGZEZVA5CNFSM4LE72LY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOLUB5Q#issuecomment-597115126>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4CPXVYP5YSLXS335P52TLRGZEZVANCNFSM4LE72LYQ> .

[fischerscode]

Sure, with the current livelist example, this change works fine.
And copying ParseObjects seems to work correct as well.

[fischerscode]

Should be fixed with #326