Possibility to pass SecurityContext to HttpClient creation

[chrbayer]

Hi, thanks for making this lib!

To support connections to a parse server with a self-signed certificate from a mobile app, I need to pass a special created SecurityContext to the creation of the HttpClient. Are there any plans to do so?
Would it help if I prepare a PR?

Thanks in advance!

Best regards,
Chris

[phillwiggins]

Hey Christopher Yeah sure, I've not actually had to do that before so I'm unsure on best approach regarding certificates. So yes, please create a PR. Cheers

…

On Tue, Feb 5, 2019, 08:04 Christoph Bayer ***@***.*** wrote: Hi, thanks for making this lib! To support connections to a parse server with a self-signed certificate from a mobile app, I need to pass a special created SecurityContext to the creation of the HttpClient. Are there any plans to do so? Would it help if I prepare a PR? Thanks in advance! Best regards, Chris — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#71>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgn3mTBScj1GHfBfrn1Ibe6OeGrGwesks5vKTsEgaJpZM4aitCZ> .

[chrbayer]

I'm working on a solution, but I have one question: Is this lib compatible with dart:html or is it built just for dart:io? It would be much nicer to implement if no compatibility with dart:html has to guaranteed.

Inside parse.dart dart:io is imported...

And just another question: I used the development branch for this PR, is that Ok?

Thanks for your support!

[phillwiggins]

Hey This lib isn't compatible with dart:html due to this lib being directly created for Flutter. (Flutter can't be used with dart:html, Sorry!) I appreciate your work! Thank you!

…

On Thu, 7 Feb 2019 at 10:51, Christoph Bayer ***@***.***> wrote: I'm working on a solution, but I have one question: Is this lib compatible with dart:html or is it built just for dart:io? It would be much nicer to implement if no compatibility with dart:html has to guaranteed. Inside parse.dart dart:io is imported... Thanks for your support! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#71 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgn3pIebti9tAetxpgisnjBqKIJJKKhks5vLAUigaJpZM4aitCZ> .

-- Kind Regards Phill Wiggins [email protected]

[chrbayer]

Hi,

that makes it a lot easier :-)

I have created a PR, can you please review? I just started to look in dart and flutter some weeks ago, so please don't hesitate to give me hints what can be made better.

Cheers,
Chris

[phillwiggins]

Hey Chris Looks interesting, I'll run some tests tonight and merge if it's looking good. Just to confirm, this PR isn't forcing users to use SecurityContext is it? I'm running through an overview of the PR and it looks to assume that there is always a SecurityContext in ParseCoreData in some areas? Is that correct? Cheers

…

On Thu, 7 Feb 2019 at 15:21, Christoph Bayer ***@***.***> wrote: Hi, that makes it a lot easier :-) I have created a PR, can you please review? I just started to look in dart and flutter some weeks ago, so please don't hesitate to give me hints what can be made better. Cheers, Chris — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#71 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgn3uGpDpVtfXSKJ9xjbxHSu01zFliJks5vLESFgaJpZM4aitCZ> .

-- Kind Regards Phill Wiggins [email protected]

[chrbayer]

Hi,

No, you do not have to use a SecurityContext, it is an optional parameter to Parse().initialize(). It should be 100% backwards compatible. There is now always a SecurityContext in ParseCoreData, but this is null in case of no context has been set. In this case the old behavior without a context is used:

ParseHTTPClient([SecurityContext securityContext])
      : _client = securityContext != null
            ? IOClient(HttpClient(context: securityContext))
            : IOClient();

[phillwiggins]

Amazing! Thank you for your work!

…

On Thu, 7 Feb 2019 at 15:42, Christoph Bayer ***@***.***> wrote: Hi, No, you do not have to use a SecurityContext, it is an optional parameter to Parse().initialize(). It should be 100% backwards compatible. There is now always a SecurityContext in ParseCoreData, but this is null in case of no context has been set. In this case the old behavior without a context is used: ParseHTTPClient([SecurityContext securityContext]) : _client = securityContext != null ? IOClient(HttpClient(context: securityContext)) : IOClient(); — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#71 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgn3opMtWdgcvaBWq51TZRO9PEmutxZks5vLEmDgaJpZM4aitCZ> .

-- Kind Regards Phill Wiggins [email protected]