-
-
Notifications
You must be signed in to change notification settings - Fork 207
Support Relation. #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Relation. #178
Conversation
# Conflicts: # CHANGELOG.md # README.md # example/lib/data/base/api_response.dart # example/lib/data/repositories/diet_plan/provider_api_diet_plan.dart # example/lib/data/repositories/diet_plan/provider_db_diet_plan.dart # example/lib/data/repositories/diet_plan/repository_diet_plan.dart # example/lib/ui/main.dart # example/test/data/repository/diet_plan/repository_diet_plan_api_test.dart # example/test/data/repository/diet_plan/repository_diet_plan_db_test.dart # example/test/data/repository/diet_plan/repository_diet_plan_test.dart # example/test/data/repository/repository_mock_utils.dart # lib/src/base/parse_constants.dart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! Thank you very much for your contribution.
Just a quick one. We have some changes that are on branch v.1.0.22. Is it possible for you to create a merge request to branch 1.0.22 and see if we can merge it there? |
Thank you. Can you look at the merge conflicts please? |
Brilliant. Thanks! |
I think this merge make some mistakes. Because it's merge from master to v.1.0.22, some change shouldn't be there. |
Which branch is affected by this? Master or v1.0.22?
…On Fri, 31 May 2019 at 14:37, 杨萧玉 ***@***.***> wrote:
I think this merge make some mistakes. Because it's merge from master to
v.1.0.22, some change shouldn't be there.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#178>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB4CPXVN3OUPMFD4DITJM2LPYESZBANCNFSM4HRW2ZLA>
.
--
Kind Regards
Phill Wiggins
[email protected]
|
Both. |
This reverts commit 6ed26e1.
Are you able to fix V1.0.22 branch and I will revert master?
…On Fri, 31 May 2019 at 14:51, 杨萧玉 ***@***.***> wrote:
Which branch is affected by this? Master or v1.0.22?
… <#m_-1496923601104661568_>
On Fri, 31 May 2019 at 14:37, 杨萧玉 *@*.***> wrote: I think this merge make
some mistakes. Because it's merge from master to v.1.0.22, some change
shouldn't be there. — You are receiving this because you modified the
open/close state. Reply to this email directly, view it on GitHub <#178
<#178>,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB4CPXVN3OUPMFD4DITJM2LPYESZBANCNFSM4HRW2ZLA
.
-- Kind Regards Phill Wiggins ***@***.***
Both.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#178>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB4CPXVCNC2SVOLAKHE6H2DPYEUP7ANCNFSM4HRW2ZLA>
.
--
Kind Regards
Phill Wiggins
[email protected]
|
OK. |
Thank you
…On Fri, 31 May 2019 at 15:45, 杨萧玉 ***@***.***> wrote:
Are you able to fix V1.0.22 branch and I will revert master?
… <#m_-2908689569781745733_>
OK.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#178>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB4CPXSN2L2X6PFJJEPPG5LPYE2W7ANCNFSM4HRW2ZLA>
.
--
Kind Regards
Phill Wiggins
[email protected]
|
This reverts commit 6ed26e1.
Hi @phillwiggins and @yulingtianxia , I just stumbled on this PR. Incidentally, I needed to query existing relations and was playing around with an implementation before seeing this PR. It appears this aspect is not implemented here (can someone confirm that?). I'm referring to the $relatedTo query explained here. The implementation is pretty straightforward (in parse_query.dart)
Can we add that to the ongoing implementation? I can make a PR if needed. @phillwiggins By the way, are there any regression tests for this lib? Pretty handy as I've seen regression in Parse Server in the past and it does help to detect that a.s.a.p. |
@sidiabale Amazing work! Your work does not conflict with this PR. This PR makes it possible to add or remove relations for some Class. You add the query API. |
Great. What branch should I make a PR to?
Op ma 3 jun. 2019 07:16 schreef 杨萧玉 <[email protected]>:
… @sidiabale <https://github.com/sidiabale> Amazing work! Your work does
not conflict with this PR. This PR makes it possible to add or remove
relations for some Class. You add the query API.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#178>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJEA5D7KM26UDKLQZRKWNLPYSSLVANCNFSM4HRW2ZLA>
.
|
Release v1.0.22 please!
…On Mon, Jun 3, 2019, 17:39 Chidiebere Okwudire ***@***.***> wrote:
Great. What branch should I make a PR to?
Op ma 3 jun. 2019 07:16 schreef 杨萧玉 ***@***.***>:
> @sidiabale <https://github.com/sidiabale> Amazing work! Your work does
> not conflict with this PR. This PR makes it possible to add or remove
> relations for some Class. You add the query API.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#178
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AAJEA5D7KM26UDKLQZRKWNLPYSSLVANCNFSM4HRW2ZLA
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#178>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB4CPXVFLMRWKSHMFMEPX53PYVCKRANCNFSM4HRW2ZLA>
.
|
@phillwiggins Done (see PR 192) |
* Added repo example * create CoreStore interface to allow different implements for local storage (parse-community#166) (parse-community#167) implement default local store using sembast and with encryption using XXTEA algorithm add desktop support in example project * Lint/Code clean * Some dart linter fixes (parse-community#171) * Support Relation. * delete vscode config * Update .gitignore
This reverts commit 6ed26e1.
Now you can use
ParseRelation
influtter_parse_sdk
.Resolve this issue: #169