Skip to content

Support Relation. #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 31, 2019
Merged

Support Relation. #178

merged 11 commits into from
May 31, 2019

Conversation

yulingtianxia
Copy link
Contributor

@yulingtianxia yulingtianxia commented May 31, 2019

Now you can use ParseRelation in flutter_parse_sdk.
Resolve this issue: #169

phillwiggins and others added 10 commits March 24, 2019 19:31
# Conflicts:
#	CHANGELOG.md
#	README.md
#	example/lib/data/base/api_response.dart
#	example/lib/data/repositories/diet_plan/provider_api_diet_plan.dart
#	example/lib/data/repositories/diet_plan/provider_db_diet_plan.dart
#	example/lib/data/repositories/diet_plan/repository_diet_plan.dart
#	example/lib/ui/main.dart
#	example/test/data/repository/diet_plan/repository_diet_plan_api_test.dart
#	example/test/data/repository/diet_plan/repository_diet_plan_db_test.dart
#	example/test/data/repository/diet_plan/repository_diet_plan_test.dart
#	example/test/data/repository/repository_mock_utils.dart
#	lib/src/base/parse_constants.dart

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…orage (#166) (#167)

implement default local store using sembast and with encryption using XXTEA algorithm

add desktop support in example project
Copy link
Member

@phillwiggins phillwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Thank you very much for your contribution.

@phillwiggins
Copy link
Member

Just a quick one. We have some changes that are on branch v.1.0.22. Is it possible for you to create a merge request to branch 1.0.22 and see if we can merge it there?

@phillwiggins
Copy link
Member

Thank you. Can you look at the merge conflicts please?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@phillwiggins phillwiggins merged commit 6ed26e1 into parse-community:master May 31, 2019
@phillwiggins
Copy link
Member

Brilliant. Thanks!

@yulingtianxia
Copy link
Contributor Author

I think this merge make some mistakes. Because it's merge from master to v.1.0.22, some change shouldn't be there.

@phillwiggins
Copy link
Member

phillwiggins commented May 31, 2019 via email

@yulingtianxia
Copy link
Contributor Author

Which branch is affected by this? Master or v1.0.22?

On Fri, 31 May 2019 at 14:37, 杨萧玉 @.***> wrote: I think this merge make some mistakes. Because it's merge from master to v.1.0.22, some change shouldn't be there. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#178?email_source=notifications&email_token=AB4CPXUUJMWC37W7WIUG5XLPYESZBA5CNFSM4HRW2ZLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWVHSYY#issuecomment-497711459>, or mute the thread https://github.com/notifications/unsubscribe-auth/AB4CPXVN3OUPMFD4DITJM2LPYESZBANCNFSM4HRW2ZLA .
-- Kind Regards Phill Wiggins [email protected]

Both.

yulingtianxia added a commit to yulingtianxia/flutter_parse_sdk that referenced this pull request May 31, 2019
@phillwiggins
Copy link
Member

phillwiggins commented May 31, 2019 via email

@yulingtianxia
Copy link
Contributor Author

Are you able to fix V1.0.22 branch and I will revert master?

OK.

@phillwiggins
Copy link
Member

phillwiggins commented May 31, 2019 via email

phillwiggins added a commit that referenced this pull request May 31, 2019
phillwiggins added a commit that referenced this pull request May 31, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This reverts commit 6ed26e1.
@sidiabale
Copy link
Contributor

Hi @phillwiggins and @yulingtianxia , I just stumbled on this PR. Incidentally, I needed to query existing relations and was playing around with an implementation before seeing this PR. It appears this aspect is not implemented here (can someone confirm that?).

I'm referring to the $relatedTo query explained here. The implementation is pretty straightforward (in parse_query.dart)

/// Retrieves related objets where [String] column is a relation field to the class [String] className
  void whereRelatedTo(String column, String className, String objectId) {
    queries.add(MapEntry<String, dynamic>(
        _SINGLE_QUERY, '\"\$relatedTo\":{\"object\":{\"__type\":\"Pointer\",\"className\":\"$className\",\"objectId\":\"$objectId\"},\"key\":\"$column\"}'));
  }

Can we add that to the ongoing implementation? I can make a PR if needed.

@phillwiggins By the way, are there any regression tests for this lib? Pretty handy as I've seen regression in Parse Server in the past and it does help to detect that a.s.a.p.

@yulingtianxia
Copy link
Contributor Author

@sidiabale Amazing work! Your work does not conflict with this PR. This PR makes it possible to add or remove relations for some Class. You add the query API.

@sidiabale
Copy link
Contributor

sidiabale commented Jun 3, 2019 via email

@phillwiggins
Copy link
Member

phillwiggins commented Jun 3, 2019 via email

@sidiabale
Copy link
Contributor

@phillwiggins Done (see PR 192)

fischerscode pushed a commit to fischerscode/Parse-SDK-Flutter that referenced this pull request Sep 5, 2020
* Added repo example

* create CoreStore interface to allow different implements for local storage (parse-community#166) (parse-community#167)

implement default local store using sembast and with encryption using XXTEA algorithm

add desktop support in example project

* Lint/Code clean

* Some dart linter fixes (parse-community#171)

* Support Relation.

* delete vscode config

* Update .gitignore
fischerscode pushed a commit to fischerscode/Parse-SDK-Flutter that referenced this pull request Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants