Skip to content

Release/1.0.22 #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Release/1.0.22 #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c7c3cb
Fix Commit: 6ed26e16964f2c316427cde02936a650a76f4159
yulingtianxia May 31, 2019
8bc98d5
Update parse_encoder.dart
yulingtianxia Jun 3, 2019
9ce5488
merge from upstream
yulingtianxia Jun 3, 2019
465a114
Fix exception when sendSessionId is null.
yulingtianxia Jun 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/network/parse_live_query.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class LiveQuery {
securityContext: ParseCoreData().securityContext);

_debug = isDebugEnabled(objectLevelDebug: debug);
_sendSessionId = autoSendSessionId ?? ParseCoreData().autoSendSessionId;
_sendSessionId = autoSendSessionId ?? ParseCoreData().autoSendSessionId ?? true;
}

WebSocket _webSocket;
Expand Down
4 changes: 2 additions & 2 deletions lib/src/utils/parse_encoder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ dynamic parseEncode(dynamic value, {bool full}) {
}

if (value is ParseGeoPoint) {
return value;
return value.toJson();
}

if (value is ParseFile) {
return value;
return value.toJson();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm quite concerned with this.

As far as I am aware ParseFile is working? What is this for?

Copy link
Contributor

@RodrigoSMarques RodrigoSMarques Jun 3, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @phillwiggins
ParseFile it's working.
This line is not necessary because the method toJson () is already called by default.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ParseGeoPoint too it's woking.

When you call a method encode in a json, toJson () is always triggered. We have Parse objects, and each class already has its toJson method with override, so just put the "value".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirmation @RodrigoSMarques

@yulingtianxia please can you remove these .toJson() calls. They are unnecessary. Thank you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phillwiggins
Before launching a new release, please contact me so I can do a regression test with my test application, just as we did the other times. Ensure that what is ready is not broken.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phillwiggins @RodrigoSMarques Thanks for explanation! Learned a lot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phillwiggins I think I should make another PR in a new branch and close this PR.

}

if (value is ParseRelation) {
Expand Down