Skip to content

Fix save #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 18, 2019
Merged

Fix save #199

merged 10 commits into from
Jun 18, 2019
+3 −24

Conversation

yulingtianxia
Copy link
Contributor

ParseGeoPoint should be simple.
This PR could fix some issue about saving objects. (#195 (comment))

@yulingtianxia
Fix Commit: 6ed26e1
2c7c3cb
@yulingtianxia
Update parse_encoder.dart
8bc98d5 
Fix parse encoder bug.
@yulingtianxia
merge from upstream
9ce5488
@yulingtianxia
Fix exception when sendSessionId is null.
465a114
@yulingtianxia
Merge branch 'release/1.0.22' of https://github.com/phillwiggins/flut…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
66f99c7 
…ter_parse_sdk into release/1.0.22
@yulingtianxia
Merge branch 'release/1.0.22' of https://github.com/phillwiggins/flut…
e6da1b5 
…ter_parse_sdk into release/1.0.22
@yulingtianxia
Merge branch 'release/1.0.22' of https://github.com/phillwiggins/flut…
90d09dd 
…ter_parse_sdk into release/1.0.22
@yulingtianxia
Merge branch 'release/1.0.22' of https://github.com/phillwiggins/flut…
e3fba7f 
…ter_parse_sdk into release/1.0.22
@yulingtianxia
Fix GeoPoint.

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 4D38170B5A2FC334
Learn about vigilant mode
589495e
@RodrigoSMarques
Copy link
Contributor

@yulingtianxia
ParseGeoPoint is not a Parse object is a data type and therefore does not extend ParseObject Class.

It is not necessary to change the parse_encode functions to put .toJson () because this method is already called by default.

This code is working properly today. I have made all the adjustments and tests.

I'm building an app that uses all these functions and everything is ok.

@yulingtianxia
Copy link
Contributor Author

@RodrigoSMarques
OMG, it's a mistake. I'll delete the two lines.

@RodrigoSMarques
Copy link
Contributor

No need toJson. When you call the jsonEncode method it is already called by default in value

https://api.dartlang.org/stable/2.4.0/dart-convert/jsonEncode.html

@yulingtianxia
Copy link
Contributor Author

@RodrigoSMarques
Thank you for your correction!
There is something wrong with my git merge. It's not intensional to add toJson. I had deleted it.

@yulingtianxia yulingtianxia mentioned this pull request Jun 18, 2019
Merged
@phillwiggins phillwiggins mentioned this pull request Jun 18, 2019
Closed
@phillwiggins phillwiggins merged commit 7c97afb into parse-community:release/1.0.22 Jun 18, 2019
@yulingtianxia yulingtianxia deleted the fix_save branch June 19, 2019 08:07
fischerscode pushed a commit to fischerscode/Parse-SDK-Flutter that referenced this pull request Sep 5, 2020
@yulingtianxia @phillwiggins
Fix save (parse-community#199)

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 4D38170B5A2FC334
Learn about vigilant mode
c819bbd 
* Fix Commit: 6ed26e1

* Update parse_encoder.dart

Fix parse encoder bug.

* Fix exception when sendSessionId is null.

* Fix GeoPoint.

* delete useless code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yulingtianxia @RodrigoSMarques @phillwiggins