Skip to content

Allow adding additional columns to ParseUser through the set call #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

VigneshPasupathy
Copy link
Contributor

ParseUser("DummyUserName", "******", "[email protected]")..set("userPhoneNumber", "123456789");

Currently ParseUser Signup only writes username, emailId, password to the User database and doesnt accept additional columns added through the .set(key, value) API even though the data is available in objectData.

Modifying the signup() code to accomodate for the same.

@phillwiggins
Copy link
Member

Hey Vignesh

Thanks for your contribution!

Is this tried and tested and all working? If so, please can you close this PR and open a new one but instead, create the pull request with the branch release/1.0.23? I'll merge it as soon as you put it through.

Thanks!

@VigneshPasupathy
Copy link
Contributor Author

Hey,
I currently have a local copy of release/1.0.22 with this piece of code for another project of mine and the updates to Back4app work fine.
Do let me know if there are any specific tests you'd want to me perform for this code base

@RodrigoSMarques
Copy link
Contributor

@VigneshPasupathy
Very good. I needed this, but no time to make this change.
@phillwiggins
do you have any plans to release this release?
I will try this week to validate with my test app.

@RodrigoSMarques
Copy link
Contributor

RodrigoSMarques commented Jul 30, 2019

@VigneshPasupathy
Please update the documentation (READ.ME) with this example.

@VigneshPasupathy
Copy link
Contributor Author

Sure @RodrigoSMarques Will update and create a pull request against release/1.0.23

@VigneshPasupathy
Copy link
Contributor Author

Closing in favor of #232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants