-
-
Notifications
You must be signed in to change notification settings - Fork 206
ParseFile should NOT extends ParseObject. #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ParseFile should NOT extends ParseObject. #233
Conversation
I think this sounds logical. Great work! |
Sorry @phillwiggins but if parseFile doesn't extend ParseObject upload doesn't work Without extending ParseObject When you extend ParseObject Please check it out for me thanks. |
Both of these are successful responses.
Just to confirm, one will send the object back as confirmation, the other
says successful but doesn't actual save?
…On Sat, 24 Aug 2019 at 03:20, pastordee ***@***.***> wrote:
ParseObject should be a table in database on parse server, but ParseFile
can't be a table.
I had found implementation of PFFileObject in iOS/OSX SDK, it's NOT a
subclass of 'PFObject'.
When ParseFile extends from ParseObject, it cause an infinite loop in
save() method.
Sorry @phillwiggins <https://github.com/phillwiggins> but if parseFile
doesn't extend ParseObject upload doesn't work
I tested it with 1.0.24 it only works when I extend ParseObject.
Without extending ParseObject
flutter: ╭-- Parse Response
*Class: null* <>
Function: ParseApiRQ.upload
Status Code: 201
Reponse: OK
When you extend ParseObject
flutter: ╭-- Parse Response
*Class: File* <>
Function: ParseApiRQ.upload
Status Code: 201
Payload: {"__type":"File","name":"****.jpg","url":"*.jpg"}
Please check it out for me thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#233>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB4CPXXMAESLITUCBZCWLU3QGCLFPANCNFSM4IIN6AYQ>
.
--
Kind Regards
Phill Wiggins
[email protected]
|
Yes |
It seems a bit strange this.
Running a few tests, this still seems to work. Logically it should not be a
ParseObject. I understand there is an issue though.
I have made a few changes and added them to the latest release branch
(release/1.0.25). Please can you test and confirm if this has fixed your
issue.
…On Sat, 24 Aug 2019 at 07:32, pastordee ***@***.***> wrote:
Yes
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#233>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB4CPXSXNENAN6JVA2ZMJLDQGDIXBANCNFSM4IIN6AYQ>
.
--
Kind Regards
Phill Wiggins
[email protected]
|
flutter: ╭-- Parse Response This works fine for me the image is saved and return the file. |
Your welcome.
I'll have a few other people run tests and ensure this works for all Parse
instances. This should be released in the next version for you.
I've never been to Essex, but if I swing by I will come say hello. Enjoy
your day!
…On Sat, 24 Aug 2019 at 08:10, pastordee ***@***.***> wrote:
flutter: ╭-- Parse Response
*Class: ParseFile*
Function: ParseApiRQ.upload
Status Code: 201
Payload: {"__type":"File","name":"*.jpg","url":"**.jpg"}
This works fine for me the image is saved and return the file.
Thanks for the great work.
PS whenever you are in ESSEX please let me know stay bless.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#233>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB4CPXTR3SRIHFARUSD5VIDQGDNEXANCNFSM4IIN6AYQ>
.
--
Kind Regards
Phill Wiggins
[email protected]
|
please can you add this to the next released parse_server_sdk.dart parse_installation.dart |
Do you know how to create pull requests?
If you can create a pull request, I'm more than happy to update the code
base for you?
…On Sat, 24 Aug 2019 at 08:20, pastordee ***@***.***> wrote:
please can you add this to the next released
parse_server_sdk.dart
import 'package:flutter_native_timezone/flutter_native_timezone.dart';
parse_installation.dart
//Timezone
final String currentTimeZone = await
FlutterNativeTimezone.getLocalTimezone();
set(keyTimeZone, currentTimeZone);
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#233>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB4CPXXYOHS6ZJPRBEUXYDLQGDOLVANCNFSM4IIN6AYQ>
.
--
Kind Regards
Phill Wiggins
[email protected]
|
Actually, I think there was an issue with this.
I think was added but removed due to it being app based only, rather than
web based too. I think it stops people using this SDK one the web.
…On Sat, 24 Aug 2019 at 08:21, Phill Wiggins ***@***.***> wrote:
Do you know how to create pull requests?
If you can create a pull request, I'm more than happy to update the code
base for you?
On Sat, 24 Aug 2019 at 08:20, pastordee ***@***.***> wrote:
> please can you add this to the next released
>
> parse_server_sdk.dart
> import 'package:flutter_native_timezone/flutter_native_timezone.dart';
>
> parse_installation.dart
> //Timezone
> final String currentTimeZone = await
> FlutterNativeTimezone.getLocalTimezone();
> set(keyTimeZone, currentTimeZone);
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#233>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AB4CPXXYOHS6ZJPRBEUXYDLQGDOLVANCNFSM4IIN6AYQ>
> .
>
--
Kind Regards
Phill Wiggins
***@***.***
--
Kind Regards
Phill Wiggins
[email protected]
|
Oh okay on the mobile it work fine, I've been using it since 1.0.21 |
ParseObject
should be a table in database on parse server, butParseFile
can't be a table.I had found implementation of
PFFileObject
in iOS/OSX SDK, it's NOT a subclass of 'PFObject'.When
ParseFile
extends fromParseObject
, it cause an infinite loop insave()
method.