Added some missing async/await #248
Merged
+32
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n await, which caused 'invalid session token' error if user ParseUser.currentUser() immediately after ParseUser.signUp() or ParseUser.login(). Added missing awaits in other places.
…ion. Reason: no safeInStorage() after save() was called. Fix: calling saveInStorage() after save().
This reverts commit dbbc5e8.
phillwiggins
pushed a commit
that referenced
this pull request
Aug 14, 2019
…/await fixes from master. (#254) * Added some missing async/await (#248) * Updated dependencies. * ParseUser._handleResponse was calling saveInStorage() async without an await, which caused 'invalid session token' error if user ParseUser.currentUser() immediately after ParseUser.signUp() or ParseUser.login(). Added missing awaits in other places. * ParseUser was not updated in storage after a successful save() operation. Reason: no safeInStorage() after save() was called. Fix: calling saveInStorage() after save(). * Revert "Updated dependencies." This reverts commit dbbc5e8. * forceUpdate was ignored when setting ParseBase properties * Setting objectData properties directly in parseJson function to prevent making decoded object properties dirty * Made forceUpdate false by default in ParseBase set method * Revert incorrect merge
fischerscode
pushed a commit
to fischerscode/Parse-SDK-Flutter
that referenced
this pull request
Sep 5, 2020
* Updated dependencies. * ParseUser._handleResponse was calling saveInStorage() async without an await, which caused 'invalid session token' error if user ParseUser.currentUser() immediately after ParseUser.signUp() or ParseUser.login(). Added missing awaits in other places. * ParseUser was not updated in storage after a successful save() operation. Reason: no safeInStorage() after save() was called. Fix: calling saveInStorage() after save(). * Revert "Updated dependencies." This reverts commit dbbc5e8.
fischerscode
pushed a commit
to fischerscode/Parse-SDK-Flutter
that referenced
this pull request
Sep 5, 2020
…/await fixes from master. (parse-community#254) * Added some missing async/await (parse-community#248) * Updated dependencies. * ParseUser._handleResponse was calling saveInStorage() async without an await, which caused 'invalid session token' error if user ParseUser.currentUser() immediately after ParseUser.signUp() or ParseUser.login(). Added missing awaits in other places. * ParseUser was not updated in storage after a successful save() operation. Reason: no safeInStorage() after save() was called. Fix: calling saveInStorage() after save(). * Revert "Updated dependencies." This reverts commit dbbc5e8. * forceUpdate was ignored when setting ParseBase properties * Setting objectData properties directly in parseJson function to prevent making decoded object properties dirty * Made forceUpdate false by default in ParseBase set method * Revert incorrect merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some functions in ParseUser declared as async were calling other async functions without the await keyword. This, for example, was causing that calling ParseUser.currentUser() right after currentUser.signUp() returned did not return the correct session id.
Additionally, user data after calling ParseUser.save was not added to storage, therefore to get latest user data you needed to sync with server first.