Release/1.0.28 #460

fischerscode · 2020-10-02T11:54:31Z

TODO before merging:

merge creat migration guide for version 1.0.28 #445
merge Move ParseHTTPClient to Dio #459
improve README (?)
modify changelog Update CHANGELOG.md #462
change parse_server_sdk dependency to pub.dev changed with 1.0.28/fix publish warnings #472

TODO after merging:

create parse_server_sdk_flutter at pub.dev
create new development branch

- Update references to 1.0.28

* Replace devicelocale by Platform.localeName call * Use flutter_test to meet new requirements

* make livequeries web implementation more similar to the mobile implementation * combining both livequery implementations * make livequery "part of flutter_parse_sdk" * smal fix

* Set TODO's Set TODO's, needed for #78 (comment) * First step of seperating the flutter and the dart parts * added one todo * remove connectivity from the dart part * Removed path_provider from the dart part Not so happy with the fact that `CoreStoreSembastImp implements sdk.CoreStoreSembastImp` in `parse_server_sdk.dart` but I didn't find a better solution. * Removed shared_preferences from the dart part * Update pubspec.yaml * Update parse_server_sdk_dart.dart * removed dart:ui from dart part * removed flutter from dart part * fixed tests

* Add websupport for CoreStoreSembastImp * Add debug warning when using sembast on web ParseCoreData().debug should be null at that time * fixed issues

Release/1.0.28

If state is equal to ConnectivityResult.none, then there is no connection with LiveQuery server (for example when internet is disconnected). _setReconnect function will now retry connection.

ConnectivityResult to ParseConnectivityResult

* split code into package directories * removed unused dependencies * Updated READMEs

….0.28

…-Flutter into release/1.0.28

Fix LiveQuery reconnect

* docs changes * remove flutter_test * CoreStore was implemented twice * implemented CoreStoreMemoryImp (default corestore for dart) * fix tests * Update .travis.yml

* fix flutter logo * fixed flutter link

Should work again.

* store password in field Potential fix for #444 * remove password from clone

Added @BaranMichal25 fix for #456. #456 (comment)

* LiveList: added preloadedColumns * LiveList: fixed bug with lazyloading=false * formatting * Add README section for flutter

* Create migrate-1-0-28.md * Update migrate-1-0-28.md * Update migrate-1-0-28.md * Update migrate-1-0-28.md * Merge from upstream/release/1.0.28 * fix typos * added "changed network library" to migration guide

fischerscode · 2020-10-02T13:28:38Z

@phillwiggins
The README of the Flutter package is in pretty good shape. The Dart's one however is almost just a copy from the Flutter's one.
Should we publish 1.0.28 with the WIP README and without an example or should we delay the release and fix those issues first?
Personally, I have not used the dart package, yet (except in short tests).
And I think adding an example and a README makes sens as soon as the package has been used in a real project, in order to gain some experience and figure out some best practices.

* Merged manually from branch dio * fixing nullpointer * Fix batch operations Maybe dio changes the toString behaviour. * use mine * keep content-type * fix file upload issue * fixed file uppload on web * performance improvement in parse_file_web * fix for issue #456 (#457) Added @BaranMichal25 fix for #456. #456 (comment) * fix flutter test * fix crash when debug=true * fix dart test * add ProgressCallback in README * added progressCallback example

fischerscode · 2020-10-08T19:03:46Z

change parse_server_sdk dependency to pub.dev (?)

Does anyone know if a relative path is allowed when publishing to pub.dev?

Added section for tests at migration guide. Fix: #385 (comment)

* signup - use toJson Co-Authored-By: itmesh <[email protected]> * fix password update

fischerscode · 2020-10-09T14:40:43Z

@phillwiggins
I think it's all ready. 👍
This PR contains all the code changes and #472 handles all of the publish warnings.
#472 fails, as parse_server_sdk: ^1.0.28 does currently not exist.

I am not quite sure if we decided to use parse_server_sdk_flutter as the flutter-package's name, or if this was a temporary thing.
Changing it should be quickly done.

This is still an option.

* Add disclaimer to not use Masterkey on client side

Fix bug where whereMatchesKeyInQuery cant be used when using different object classes.

Not sure how this line got lost.

phillwiggins · 2020-10-11T06:36:56Z

Okay cool.

@fischerscode The release process does not depend on this being merged in, however, we should do that straight way. Which package shall I release? Shall I just release the Flutter project at the moment or would you like me to publish both?

fischerscode · 2020-10-11T07:46:57Z

@phillwiggins

Shall I just release the Flutter project at the moment

I didn't thought about that option, it sounds good, too. But we would have to replace this with something like this.

  parse_server_sdk:
    git:
      url: git://github.com/parse-community/Parse-SDK-Flutter.git
      ref: release/1.0.28
      path: packages/dart

But then flutter pub publish --dry-run for the flutter package results in this warning:

Package validation found the following potential issue:
* Don't depend on "parse_server_sdk" from the git source. Use the hosted source instead. For example:
  
  dependencies:
    parse_server_sdk: ^1.0.27
  
  Using the hosted source ensures that everyone can download your package's dependencies along with your package.

Package has 1 warning.
pub finished with exit code 65

So I think publishing both packages is the only option.

phillwiggins · 2020-10-11T08:04:36Z

Oh okay. I'm not quite sure what the best way forward is for that. Would I publish the package as normal or from the root? I'd imagine if it is from root, it will never be split into 2 packages.

…

On Sun, 11 Oct 2020, 08:47 Maximilian Fischer, ***@***.***> wrote: @phillwiggins <https://github.com/phillwiggins> Shall I just release the Flutter project at the moment I didn't thought about that option, it sounds good, too. But we would have to replace this <https://github.com/parse-community/Parse-SDK-Flutter/blob/7a4d4a4f51abe6ee69a1ffe829c32da987cd4412/packages/flutter/pubspec.yaml#L13> with something like this. parse_server_sdk: git: url: git://github.com/parse-community/Parse-SDK-Flutter.git ref: release/1.0.28 path: packages/dart But then flutter pub publish --dry-run for the flutter package results in this warning: Package validation found the following potential issue: * Don't depend on "parse_server_sdk" from the git source. Use the hosted source instead. For example: dependencies: parse_server_sdk: ^1.0.27 Using the hosted source ensures that everyone can download your package's dependencies along with your package. Package has 1 warning. pub finished with exit code 65 So I think publishing both packages is the only option. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#460 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4CPXXI3HX4KOQOTAO4U7DSKFPH3ANCNFSM4SBTKCGQ> .

fischerscode · 2020-10-11T08:41:57Z

I think you have to run the publish command inside of packages/dart as well as inside of packages/flutter. At least that's how I run flutter pub publish --dry-run.

phillwiggins · 2020-10-11T08:44:30Z

Okay cool. Will do that now.

…

On Sun, 11 Oct 2020, 09:42 Maximilian Fischer, ***@***.***> wrote: I think you have to run the publish command inside of packages/dart as well as inside of packages/flutter. At least that's how I run flutter pub publish --dry-run. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#460 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4CPXWBFMLT4FIQTDMGQFTSKFVWDANCNFSM4SBTKCGQ> .

phillwiggins · 2020-10-11T09:15:30Z

Both have been published. I had to amend the Flutter dependency. It is required to point at the dart parse server sdk on pub.dev to work. I've not tested it yet, but let me know how it goes.

…

On Sun, 11 Oct 2020 at 09:44, Phill Wiggins ***@***.***> wrote: Okay cool. Will do that now. On Sun, 11 Oct 2020, 09:42 Maximilian Fischer, ***@***.***> wrote: > I think you have to run the publish command inside of packages/dart as > well as inside of packages/flutter. At least that's how I run flutter > pub publish --dry-run. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#460 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AB4CPXWBFMLT4FIQTDMGQFTSKFVWDANCNFSM4SBTKCGQ> > . >

-- Kind Regards Phill Wiggins [email protected]

fischerscode · 2020-10-11T09:30:27Z

@phillwiggins
Great. I've changed the dependency in my app. It seems to work.
You have published from the current release 1.0.28 branch including the changes from #472, right?
If you don't mind, I would merge #472, then #460 and create a new dev branch (1.0.29(?)) afterwards.

phillwiggins · 2020-10-11T09:31:19Z

That is correct.

…

On Sun, 11 Oct 2020 at 10:30, Maximilian Fischer ***@***.***> wrote: @phillwiggins <https://github.com/phillwiggins> Great. I've changed the dependency in my app. It seems to work. You have published from the current release 1.0.28 branch including the changes from #472 <#472>, right? If you don't mind, I would merge #472 <#472>, then #460 <#460> and create a new dev branch (1.0.29(?)) afterwards. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#460 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4CPXX3QSAKHEUTSUOUYUDSKF3MBANCNFSM4SBTKCGQ> .

-- Kind Regards Phill Wiggins [email protected]

* added licenses I've just copied the LICENSE file. * change dependencies at dart/pubspec.yaml * change dependencies at flutter/pubspec.yaml

It's contained in the pub.spec archive, so I add it here.

fischerscode · 2020-10-11T10:20:16Z

@phillwiggins
I think it's all done now.
Just two more things:

https://pub.dev/packages/parse_server_sdk says, that the package is only for dart-native. I think dart-web should work, too. And it says it's a dart and flutter package. Even through this is technically correct, wouldn't it be reasonable to remove the flutter label, as the flutter package should be used for flutter projects?
And I think, https://pub.dev/packages/parse_server_sdk_flutter should now show the web compatibility label.

phillwiggins · 2020-10-11T10:51:43Z

I think (not 100% certain) that these tags are supplied via the pubspec.yaml. I think there's some types of flags that dictate which badges are set on the pub.dev page. I might need to look further into that.

…

On Sun, 11 Oct 2020 at 11:20, Maximilian Fischer ***@***.***> wrote: @phillwiggins <https://github.com/phillwiggins> I think it's all done now. Just two more things: - https://pub.dev/packages/parse_server_sdk says, that the package is only for dart-native. I think dart-web should work, too. And it says it's a dart and flutter package. Even through this is technically correct, wouldn't it be reasonable to remove the flutter label, as the flutter package should be used for flutter projects? - And I think, https://pub.dev/packages/parse_server_sdk_flutter should now show the web compatibility label. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#460 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4CPXUYW7ROZVYU2QUXAT3SKGBGZANCNFSM4SBTKCGQ> .

-- Kind Regards Phill Wiggins [email protected]

fischerscode · 2020-10-11T11:39:03Z

@phillwiggins
I think, you are right. https://pub.dev/help/scoring#support-multiple-platforms
The web label for the dart package may be absent, as files like this do not have a default, that's independent from all platforms.
Should we add this to the next release or is updating a package possible?

fischerscode · 2020-10-11T11:45:33Z

as files like this do not have a default, that's independent from all platforms.

It should be done like so

phillwiggins · 2020-10-11T12:14:05Z

Your call. I don't mind releasing it again? Bump it to 1.0.28+1

…

On Sun, 11 Oct 2020, 12:39 Maximilian Fischer, ***@***.***> wrote: @phillwiggins <https://github.com/phillwiggins> I think, you are right. https://pub.dev/help/scoring#support-multiple-platforms The web label for the dart package may be absent, as files like this <https://github.com/parse-community/Parse-SDK-Flutter/blob/master/packages/dart/lib/src/network/http_client_adapter.dart> do not have a default, that's independent from all platforms. Should we add this to the next release or is updating a package possible? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#460 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4CPXQ4SEJT5PNNRZ2F4DLSKGKOHANCNFSM4SBTKCGQ> .

fischerscode · 2020-10-11T12:17:16Z

Your call. I don't mind releasing it again? Bump it to 1.0.28+1

All right, I will push a commit later.

fischerscode · 2020-10-11T21:18:23Z

I will push a commit later

Unfortunately I ran out of time today. I am going to get back to this tomorrow.

phillwiggins and others added 23 commits August 28, 2020 08:38

Release 1.0.28 - Create new release branch

31e54d0

- Update references to 1.0.28

Replace devicelocale by Platform.localeName call (#430)

7462a01

* Replace devicelocale by Platform.localeName call * Use flutter_test to meet new requirements

Livequery: combine both implementations (#433)

efbb9c6

* make livequeries web implementation more similar to the mobile implementation * combining both livequery implementations * make livequery "part of flutter_parse_sdk" * smal fix

Add WEB-support for CoreStoreSembastImp (#436)

d9a6171

* Add websupport for CoreStoreSembastImp * Add debug warning when using sembast on web ParseCoreData().debug should be null at that time * fixed issues

fix getInstance of CoreStoreSembastImp (#438)

f07909f

Merge pull request #1 from parse-community/release/1.0.28

9c76d67

Release/1.0.28

Reset _isConnected var

bfc7615

If state is equal to ConnectivityResult.none, then there is no connection with LiveQuery server (for example when internet is disconnected). _setReconnect function will now retry connection.

Fixed bad type

d0d12e5

ConnectivityResult to ParseConnectivityResult

Merge remote-tracking branch 'upstream/release/1.0.28' into release/1…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

9186e86

….0.28

Merge branch 'release/1.0.28' of https://github.com/FNPCMDs/Parse-SDK…

3af7531

…-Flutter into release/1.0.28

Merge pull request #440 from FNPCMDs/release/1.0.28

745b054

Fix LiveQuery reconnect

Small changes and improvements (#441)

d41596a

* docs changes * remove flutter_test * CoreStore was implemented twice * implemented CoreStoreMemoryImp (default corestore for dart) * fix tests * Update .travis.yml

Fix links (#443)

6239620

* fix flutter logo * fixed flutter link

Fix infinite connecting on web

6e0f0b4

delete old example folder

996c8c0

fixing travis tests (#447)

056ae2a

Should work again.

Fixed throw in live list stream (#448)

6bbc156

ParseUser: store password in field (#446)

b9f51a6

* store password in field Potential fix for #444 * remove password from clone

fix for issue #456 (#457)

fca5cb8

Added @BaranMichal25 fix for #456. #456 (comment)

LiveList: preloadedColumns (#458)

fd52b84

* LiveList: added preloadedColumns * LiveList: fixed bug with lazyloading=false * formatting * Add README section for flutter

creat migration guide for version 1.0.28 (#445)

74c4845

* Create migrate-1-0-28.md * Update migrate-1-0-28.md * Update migrate-1-0-28.md * Update migrate-1-0-28.md * Merge from upstream/release/1.0.28 * fix typos * added "changed network library" to migration guide

fischerscode mentioned this pull request Oct 8, 2020

improve Readme for 1.0.28 #468

Merged

fischerscode added 3 commits October 8, 2020 18:11

improve readme (#468)

95c83b5

Update CHANGELOG.md (#462)

583bfb8

allow signup without email (#469)

e8e1bb6

fischerscode added 2 commits October 9, 2020 13:19

Update migrate-1-0-28.md (#471)

ee68a84

Added section for tests at migration guide. Fix: #385 (comment)

SignUp encoding data to JSON (#470)

65b5a48

* signup - use toJson Co-Authored-By: itmesh <[email protected]> * fix password update

fischerscode marked this pull request as ready for review October 9, 2020 14:37

nstrelow and others added 4 commits October 9, 2020 20:52

Add disclaimer to not use Masterkey on client side (#474)

ceb17f6

* Add disclaimer to not use Masterkey on client side

LiveList: fix setState after dispose (#475)

4622e29

Querybuilder: whereMatchesKeyInQuery bugfix (#476)

eee69fc

Fix bug where whereMatchesKeyInQuery cant be used when using different object classes.

fixed liveListRetryIntervals in flutter

b0dd5b8

Not sure how this line got lost.

phillwiggins added 2 commits October 11, 2020 09:54

Rel 1.0.28: Add license to sub-projects

4d43411

Rel 1.0.28: Add dependencies required for rel

e648f0a

fischerscode added 2 commits October 11, 2020 11:47

1.0.28/fix publish warnings (#472)

9d0d888

* added licenses I've just copied the LICENSE file. * change dependencies at dart/pubspec.yaml * change dependencies at flutter/pubspec.yaml

flutter: added dio to pubspec.yaml

9eca393

It's contained in the pub.spec archive, so I add it here.

fischerscode merged commit e35d28d into master Oct 11, 2020

fischerscode mentioned this pull request Oct 12, 2020

Migrate to 1.0.28 - Problem with CoreStoreSembastImp #478

Closed

mtrezza deleted the release/1.0.28 branch May 30, 2022 21:48

Release/1.0.28 #460

Release/1.0.28 #460

Conversation

fischerscode commented Oct 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fischerscode commented Oct 2, 2020

Uh oh!

fischerscode commented Oct 8, 2020

Uh oh!

fischerscode commented Oct 9, 2020

Uh oh!

phillwiggins commented Oct 11, 2020

Uh oh!

fischerscode commented Oct 11, 2020

Uh oh!

phillwiggins commented Oct 11, 2020 via email

Uh oh!

fischerscode commented Oct 11, 2020

Uh oh!

phillwiggins commented Oct 11, 2020 via email

Uh oh!

phillwiggins commented Oct 11, 2020 via email

Uh oh!

fischerscode commented Oct 11, 2020

Uh oh!

phillwiggins commented Oct 11, 2020 via email

Uh oh!

fischerscode commented Oct 11, 2020

Uh oh!

phillwiggins commented Oct 11, 2020 via email

Uh oh!

fischerscode commented Oct 11, 2020

Uh oh!

fischerscode commented Oct 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phillwiggins commented Oct 11, 2020 via email

Uh oh!

fischerscode commented Oct 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fischerscode commented Oct 11, 2020

Uh oh!

fischerscode commented Oct 2, 2020 •

edited

Loading

fischerscode commented Oct 11, 2020 •

edited

Loading

fischerscode commented Oct 11, 2020 •

edited

Loading