Skip to content

Fix LiveQuery: wont add element to empty list #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2021
Merged

Fix LiveQuery: wont add element to empty list #608

merged 2 commits into from
Apr 29, 2021

Conversation

fischerscode
Copy link
Contributor

original PR: #585

Version 2.1.0 has a bug, where new rows won't be added to an empty list.

This occurred, as the animated list was not build in case of an empty list. Resulting in _animatedListKey.currentState being null. By using a stack to view both widgets, this should be fixed without any side effects.

The queryEmptyElement is now also animated.

I've recreated this PR, as the original has been quite old and there have been some changes in the files.

@fischerscode
fix livequery
50e9329 
wont add element to empty list
@fischerscode fischerscode mentioned this pull request Apr 23, 2021
Closed
@fischerscode
Copy link
Contributor Author

Merging this now, as it seems to fix the issue.

@fischerscode fischerscode merged commit ab9a1bc into parse-community:nullsafety Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fischerscode