Skip to content

fix: various bugs #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 57 commits into from
Jul 7, 2022
Merged

Conversation

RodrigoSMarques
Copy link
Contributor

@RodrigoSMarques RodrigoSMarques commented Jun 2, 2022

Bug Fixes

  • Old version of connectivity_plus package (#717)
  • package_info_plus not work in web (#714)
  • MissingPluginException (No implementation found for method getAll) (#712)
  • Query fails for subclassed Parse object in Parse relation (#697)
  • ParseRelation#query - Unhandled Exception: type 'ParseObject' is not a subtype of type (#696)
  • Error in progressCallback (#679)
  • first: Correct return type (#661)
  • ParseLiveListWidget MongoError (#653)
  • Unexpected null value after call user.logout() (#770)

General improvements

  • Updated dependencies
  • Fix Label Platform Web Support in pub.dev - Refactor path_provider access

tk2232 and others added 30 commits July 4, 2021 20:37
ParseLiveListWidget is sending the wrong GET request if lazyloading is enabled and no order limiter is set.
We have to check if there is a key to send
Updated Readme.md to include information about some extra steps to support for the desktop - macOS platform to connect to the Web and retrive/store information on Parse server due to the changes in the macOS framwork after macOS 10.7 so that user's using the Parse SDK Flutter can get their app running quick and without issues.
Update Readme.md to add info about supporting macOS platform
…ubspec.yaml

Fix logout error when no user is logged in
Update dependencies in pubspec.yaml
Fixes for version 3.2.0
Remove unnecessary files from the project
ParseLiveListWidget is sending the wrong GET request if lazyloading is enabled and no order limiter is set.
We have to check if there is a key to send
Updated Readme.md to include information about some extra steps to support for the desktop - macOS platform to connect to the Web and retrive/store information on Parse server due to the changes in the macOS framwork after macOS 10.7 so that user's using the Parse SDK Flutter can get their app running quick and without issues.
@RodrigoSMarques
Copy link
Contributor Author

@fischerscode do you have any idea why this is failing in the CI?

Run echo "publish_to: none" >> packages/flutter/pubspec.yaml
  echo "publish_to: none" >> packages/flutter/pubspec.yaml
  tools/flutter-dependencies.sh
  shell: /usr/bin/bash -e {0}
  env:
    FLUTTER_ROOT: /opt/hostedtoolcache/flutter
    PUB_CACHE: /opt/hostedtoolcache/flutter/.pub-cache
/home/runner/work/_temp/77210dd4-30c5-471c-9082-3b4ab7de3cde.sh: line 2: tools/flutter-dependencies.sh: Permission denied
Error: Process completed with exit code 126.

@mtrezza fixing with PR #766

@mtrezza
Copy link
Member

mtrezza commented Jun 28, 2022

Merged the fix, let's see if CI passes now

@mtrezza
Copy link
Member

mtrezza commented Jun 28, 2022

It's strange that this issue only occurs for the windows-latest CI task:

ERR : Because parse_server_sdk_flutter depends on parse_server_sdk ^3.1.2 which doesn't match any versions, version solving failed.

Why is that? I assume for the test it should resolve the locally installed version, but maybe that linking fails on windows?

@RodrigoSMarques
Copy link
Contributor Author

It's strange that this issue only occurs for the windows-latest CI task:

ERR : Because parse_server_sdk_flutter depends on parse_server_sdk ^3.1.2 which doesn't match any versions, version solving failed.

Why is that? I assume for the test it should resolve the locally installed version, but maybe that linking fails on windows?

On Linux/Mac, the file flutter-dependencies.sh runs
On Windows we should have a flutter-dependencies.bat that performs the same function.
Can I create the file and change the action to call the bat file

@mtrezza
Copy link
Member

mtrezza commented Jun 28, 2022

Can I create the file and change the action to call the bat file

That would be good! Maybe in a separate small PR?

@RodrigoSMarques
Copy link
Contributor Author

Can I create the file and change the action to call the bat file

That would be good! Maybe in a separate small PR?

Yes. PR #769

@mtrezza
Copy link
Member

mtrezza commented Jun 28, 2022

This thread may be difficult to read since it's quite long, I think the only open point is #762 (comment).

@mtrezza
Copy link
Member

mtrezza commented Jun 28, 2022

Oh interesting, windows still fails.

@RodrigoSMarques
Copy link
Contributor Author

Oh interesting, windows still fails.

I found the reason. I will send new PR.

The flutter command in windows is a .bat file

If you call a .bat from within another .bat file, it does not complete processing.

You need to run the commands with call

@RodrigoSMarques
Copy link
Contributor Author

@mtrezza everything ok now

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RodrigoSMarques
Copy link
Contributor Author

@mtrezza
Is there any pending to release this version?

@mtrezza
Copy link
Member

mtrezza commented Jul 6, 2022

See my previous comment

@RodrigoSMarques
Copy link
Contributor Author

See #762 (comment)

Bug #770

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for all the fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected null value after call user.logout()
7 participants