Skip to content

fix: the Response from DioError could return null from the data property but String is expected in ParseNetworkResponse #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

fix: the Response from DioError could return null from the data property but String is expected in ParseNetworkResponse #775

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e17bb65
fix bug#774: null is not a subtype of String
Nidal-Bakir Jul 9, 2022
cad42c7
extract fallbackErrorData geter in case of null data error response f…
Nidal-Bakir Jul 9, 2022
44da385
Merge branch 'master' of https://github.com/parse-community/Parse-SDK…
Nidal-Bakir Jul 10, 2022
a19cdc3
Merge branch 'master' into bug_fix#774
Nidal-Bakir Jul 10, 2022
46eae42
Merge branch 'bug_fix#774' of https://github.com/Nidal-Bakir/Parse-SD…
Nidal-Bakir Jul 10, 2022
2b3b05d
fix json format, Add quotation mark to make sure the dart will parse …
Nidal-Bakir Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions packages/dart/lib/src/network/parse_dio_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ class ParseDioClient extends ParseClient {
data: dioResponse.data!, statusCode: dioResponse.statusCode!);
} on dio.DioError catch (error) {
return ParseNetworkResponse(
data: error.response?.data, statusCode: error.response!.statusCode!);
data: error.response?.data ?? _fallbackErrorData,
statusCode: error.response!.statusCode!,
Copy link
Member

@mbfakourii mbfakourii Nov 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran this code without internet connection and got null error in statusCode!
I suggest you change the code like this

return ParseNetworkResponse(
  data: error.response?.data ?? _fallbackErrorData,
  statusCode: error.response?.statusCode! ?? ParseError.otherCause,
);

);
}
}

Expand All @@ -51,7 +53,9 @@ class ParseDioClient extends ParseClient {
bytes: dioResponse.data, statusCode: dioResponse.statusCode!);
} on dio.DioError catch (error) {
return ParseNetworkByteResponse(
data: error.response?.data, statusCode: error.response!.statusCode!);
data: error.response?.data ?? _fallbackErrorData,
statusCode: error.response!.statusCode!,
);
}
}

Expand All @@ -68,7 +72,9 @@ class ParseDioClient extends ParseClient {
data: dioResponse.data!, statusCode: dioResponse.statusCode!);
} on dio.DioError catch (error) {
return ParseNetworkResponse(
data: error.response?.data, statusCode: error.response!.statusCode!);
data: error.response?.data ?? _fallbackErrorData,
statusCode: error.response!.statusCode!,
);
}
}

Expand All @@ -85,7 +91,9 @@ class ParseDioClient extends ParseClient {
data: dioResponse.data!, statusCode: dioResponse.statusCode!);
} on dio.DioError catch (error) {
return ParseNetworkResponse(
data: error.response?.data, statusCode: error.response!.statusCode!);
data: error.response?.data ?? _fallbackErrorData,
statusCode: error.response!.statusCode!,
);
}
}

Expand All @@ -105,7 +113,9 @@ class ParseDioClient extends ParseClient {
data: dioResponse.data!, statusCode: dioResponse.statusCode!);
} on dio.DioError catch (error) {
return ParseNetworkResponse(
data: error.response?.data, statusCode: error.response!.statusCode!);
data: error.response?.data ?? _fallbackErrorData,
statusCode: error.response!.statusCode!,
);
}
}

Expand All @@ -121,9 +131,13 @@ class ParseDioClient extends ParseClient {
data: dioResponse.data!, statusCode: dioResponse.statusCode!);
} on dio.DioError catch (error) {
return ParseNetworkResponse(
data: error.response?.data, statusCode: error.response!.statusCode!);
data: error.response?.data ?? _fallbackErrorData,
statusCode: error.response!.statusCode!,
);
}
}

String get _fallbackErrorData => '{"$keyError":"NetworkError"}';
}

/// Creates a custom version of HTTP Client that has Parse Data Preset
Expand Down