Skip to content

refactor: Fix deprecations and other warnings #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 21, 2022
Merged

refactor: Fix deprecations and other warnings #810

merged 3 commits into from
Dec 21, 2022

Conversation

mbfakourii
Copy link
Member

@mbfakourii mbfakourii commented Dec 20, 2022

New Pull Request Checklist

Issue Description

Solve 25 warnings in dart and flutter package
fix deprecated functions
fix some spelling mistakes
remove unnecessary folder
rename variables names based on dart principles (1)

Closes: #733

Approach

n/a

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry

fix deprecated functions
fix some spelling mistakes
remove unnecessary folder
@parse-github-assistant
Copy link

parse-github-assistant bot commented Dec 20, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mbfakourii mbfakourii changed the title Solve 25 warnings fix: Solving warnings Dec 20, 2022
@mbfakourii mbfakourii changed the title fix: Solving warnings fix: Fix warnings Dec 20, 2022
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 10.55% // Head: 10.56% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (28bbba8) compared to base (60ca5a4).
Patch coverage: 6.66% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #810   +/-   ##
=======================================
  Coverage   10.55%   10.56%           
=======================================
  Files          47       47           
  Lines        2841     2840    -1     
=======================================
  Hits          300      300           
+ Misses       2541     2540    -1     
Impacted Files Coverage Δ
...ackages/dart/lib/src/network/parse_live_query.dart 0.00% <0.00%> (ø)
...kages/dart/lib/src/network/parse_websocket_io.dart 0.00% <ø> (ø)
packages/dart/lib/src/utils/parse_live_list.dart 0.00% <0.00%> (ø)
...ackages/flutter/lib/src/utils/parse_live_grid.dart 0.00% <0.00%> (ø)
...ackages/flutter/lib/src/utils/parse_live_list.dart 0.00% <0.00%> (ø)
packages/dart/lib/src/network/parse_query.dart 10.20% <18.51%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza mtrezza mentioned this pull request Dec 21, 2022
4 tasks
@mtrezza mtrezza changed the title fix: Fix warnings refactor: Fix deprecations and other warnings Dec 21, 2022
@mtrezza
Copy link
Member

mtrezza commented Dec 21, 2022

Since this is not changing the product behavior and doesn't fix a bug, I changed the commit type to refactor.
When this is ready for review please request a review from @parse-community/flutter-sdk-review.

@mbfakourii mbfakourii requested review from fischerscode, phillwiggins, RodrigoSMarques and a team and removed request for a team, phillwiggins, RodrigoSMarques and fischerscode December 21, 2022 13:04
Copy link
Member Author

@mbfakourii mbfakourii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rechecked the code and it seems to be fine

@mtrezza mtrezza merged commit 26b8698 into parse-community:master Dec 21, 2022
@mbfakourii mbfakourii deleted the path-4 branch May 23, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixing the analyzer infos
2 participants