-
-
Notifications
You must be signed in to change notification settings - Fork 206
fix: Time zone data not set in ParseInstallation
#811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Time zone data not set in ParseInstallation
#811
Conversation
Thanks for opening this pull request!
|
Codecov ReportBase: 13.63% // Head: 15.13% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #811 +/- ##
==========================================
+ Coverage 13.63% 15.13% +1.49%
==========================================
Files 47 47
Lines 2846 2855 +9
==========================================
+ Hits 388 432 +44
+ Misses 2458 2423 -35
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ParseInstallation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test?
test added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! If you would like to add the changelog entry, then we can publish a release.
added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
New Pull Request Checklist
Issue Description
fix ParseInstallation timeZone missing
Closes: #96
Approach
Added a new way to get the time zone name
TODOs before merging