Skip to content

fix: Time zone data not set in ParseInstallation #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 16, 2023
Merged

fix: Time zone data not set in ParseInstallation #811

merged 12 commits into from
Jan 16, 2023

Conversation

mbfakourii
Copy link
Member

@mbfakourii mbfakourii commented Dec 22, 2022

New Pull Request Checklist

Issue Description

fix ParseInstallation timeZone missing

Closes: #96

Approach

Added a new way to get the time zone name

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry

@parse-github-assistant
Copy link

parse-github-assistant bot commented Dec 22, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 13.63% // Head: 15.13% // Increases project coverage by +1.49% 🎉

Coverage data is based on head (d48de70) compared to base (cd6b544).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head d48de70 differs from pull request most recent head d99c862. Consider uploading reports for the commit d99c862 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #811      +/-   ##
==========================================
+ Coverage   13.63%   15.13%   +1.49%     
==========================================
  Files          47       47              
  Lines        2846     2855       +9     
==========================================
+ Hits          388      432      +44     
+ Misses       2458     2423      -35     
Impacted Files Coverage Δ
packages/dart/lib/parse_server_sdk.dart 28.57% <ø> (ø)
...kages/dart/lib/src/objects/parse_installation.dart 28.92% <100.00%> (+28.92%) ⬆️
packages/dart/lib/src/objects/parse_base.dart 46.78% <0.00%> (+1.83%) ⬆️
packages/dart/lib/src/data/parse_core_data.dart 71.73% <0.00%> (+4.34%) ⬆️
...ckages/dart/lib/src/storage/core_store_memory.dart 17.24% <0.00%> (+17.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza mtrezza changed the title fix: ParseInstallation timeZone missing fix: Time zone data not set in ParseInstallation Dec 23, 2022
@mbfakourii mbfakourii requested a review from mtrezza January 11, 2023 19:16
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test?

@mbfakourii
Copy link
Member Author

Could you add a test?

test added

mtrezza
mtrezza previously approved these changes Jan 14, 2023
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! If you would like to add the changelog entry, then we can publish a release.

@mbfakourii
Copy link
Member Author

Looks good! If you would like to add the changelog entry, then we can publish a release.

added

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit 7f24fb2 into parse-community:master Jan 16, 2023
@mbfakourii mbfakourii deleted the fix_parseInstallation_timeZone_missing branch May 23, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParseInstallation timeZone missing
2 participants