Skip to content

added call to logout endpoint #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2019
Merged

added call to logout endpoint #84

merged 1 commit into from
Feb 20, 2019

Conversation

rickspencer3
Copy link
Contributor

to address #83

phillwiggins
phillwiggins approved these changes Feb 20, 2019
View reviewed changes
Copy link
Member

@phillwiggins phillwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good effort.

Good work, thank you.

@phillwiggins phillwiggins merged commit 3ab44bc into parse-community:master Feb 20, 2019
chrbayer
chrbayer reviewed Feb 20, 2019
View reviewed changes
Copy link
Contributor

@chrbayer chrbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation is not correct:

  • logout should return Furture
  • the if in the try is useless, because the the data has already been deleted before

@phillwiggins phillwiggins mentioned this pull request Jun 18, 2019
Closed
fischerscode pushed a commit to fischerscode/Parse-SDK-Flutter that referenced this pull request Sep 5, 2020
@phillwiggins
Merge pull request parse-community#84 from rapido-mobile/logout
a751ac9 
added call to logout endpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrbayer chrbayer chrbayer left review comments

@phillwiggins phillwiggins phillwiggins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickspencer3 @phillwiggins @chrbayer