Skip to content

docs: Remove unnecessary lines in README #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 28, 2023
Merged

docs: Remove unnecessary lines in README #927

merged 7 commits into from
May 28, 2023
+0 −7

Conversation

mbfakourii
Copy link
Member

Pull Request

Issue

Closes: #885

Approach

There are some extra lines at the end of README.mds that are not in the rest of the Parse repastories, I think it is better to delete them.

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

Sorry, something went wrong.

@parse-github-assistant
Copy link

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented May 28, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (4e4bfab) 38.51% compared to head (a41c9de) 38.51%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #927   +/-   ##
=======================================
  Coverage   38.51%   38.51%           
=======================================
  Files          60       60           
  Lines        3331     3331           
=======================================
  Hits         1283     1283           
  Misses       2048     2048

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mbfakourii
Copy link
Member Author

mbfakourii commented May 28, 2023 •
edited
Loading

@mtrezza

I noticed this after the merge 😔

@mbfakourii mbfakourii changed the title refactor: Remove unnecessary lines from 'README.md's refactor: Remove unnecessary lines from README.mds May 28, 2023
@mtrezza mtrezza changed the title refactor: Remove unnecessary lines from README.mds docs: Remove unnecessary lines from README.mds May 28, 2023
@mtrezza mtrezza changed the title docs: Remove unnecessary lines from README.mds docs: Remove unnecessary lines in README May 28, 2023
mtrezza
mtrezza approved these changes May 28, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can we merge this?

@mbfakourii
Copy link
Member Author

Looks good, can we merge this?

Yes

@mtrezza mtrezza merged commit 19bbb6f into parse-community:master May 28, 2023
@mbfakourii mbfakourii deleted the remove_unnecessary_line branch October 3, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document improvement
2 participants
@mbfakourii @mtrezza